From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15979 invoked by alias); 3 Mar 2011 17:33:11 -0000 Received: (qmail 15963 invoked by uid 22791); 3 Mar 2011 17:33:10 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_TM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 17:33:06 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 67DF751004; Thu, 3 Mar 2011 09:33:05 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 5D448C9EDA; Thu, 3 Mar 2011 09:33:05 -0800 (PST) Message-ID: <4D6FD0D1.6000506@vmware.com> Date: Thu, 03 Mar 2011 17:33:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint References: <4D6EDDBB.9030809@vmware.com> <201103030948.22048.pedro@codesourcery.com> In-Reply-To: <201103030948.22048.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00190.txt.bz2 Pedro Alves wrote: > On Thursday 03 March 2011 00:15:55, Michael Snyder wrote: >> checked in. > >> 2011-03-02 Michael Snyder >> >> * cli/cli-script.c (script_from_file): Add break for lint. > >> throw_error (e.error, >> _("%s:%d: Error in sourced command file:\n%s"), >> source_file_name, source_line_number, e.message); >> + break; /* lint */ > > Please don't. Teach lint about the no-return property of throw_error instead. > >> default: >> internal_error (__FILE__, __LINE__, _("bad reason")); >> } > I used "lint" loosely, to mean any checker including a human. It makes things clearer. There is plenty of precident in gdb: language.c: return (struct type *) 0; /* For lint */ mt-tdep.c: default: /* lint */ valarith.c: return 0; /* For lint -- never reached */ valops.c: return 0; /* For lint -- never reached. */ value.c: return 0; /* Placate lint. */