Re: [PATCH 02/11] gdb: rename search_symtabs_expansion_listener -> compunit_symtab_iteration_callback

[Simon Marchi <simon.marchi@polymtl.ca>]

On 4/16/26 4:16 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> I think that the name search_symtabs_expansion_listener function type
> no longer makes sense for the following reasons:
> 
>  - Since we have both `symtab` and `compunit_symtab` structs, I like
>    when we are specific about which one we're talking about.  In this
>    case, the callback takes a `compunit_symtab`.
> 
>  - Following series "Search symbols via quick API" [1] last year (I
>    believe commit f88f9f42db8 ("Have expand_symtabs_matching work for
>    already-expanded CUs")), the callback gets called for all matching
>    compunit_symtabs, not just those that get expanded.
> 
> I therefore propose to rename it to compunit_symtab_iteration_callback.
> I chose "callback" over "listener", because I think that listener
> implies that there is some event happening, that we listen for.  That
> made sense before where we would listen for the "expansion" event.  But
> now since it just gets called back for all matching CUs, I think that
> "callback" makes more sense.
> 
> I renamed the parameters accordingly.
> 
> [1] https://inbox.sourceware.org/gdb-patches/20250909-search-in-psyms-v4-0-e7ef9e3b6479@tromey.com/
> 
> Change-Id: Ia5a662e6d37caf8e0272424ddbbd82f05bdb5ebe

Andrew, you sent Approved-Bys for all patches except this one, is it
just an oversight?

Simon