Re: [PATCH 03/11] gdb: introduce iteration_status enum, use it for search callbacks

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> There are a bunch of iteration functions that take a callback returning
Simon> true or false to indicate whether to continue or stop iterating.  These
Simon> functions then return the same value, indicate whether the iteration was
Simon> done until the end of interrupted.  I think this is confusing and
Simon> error-prone, as I never know which value means what.  It is especially
Simon> confusing when two opposite conventions collide, such as in
Simon> objfile::map_symtabs_matching_filename.

Simon> I propose to make that more obvious by introducing a new
Simon> iteration_status enum with self-documenting values.

Thanks for doing this.

Tom