Re: [PATCH 10/11] gdb: make symbol_found_callback_ftype a function_view

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simon.marchi@efficios.com> writes:

> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> All uses of symbol_found_callback_ftype use it within a function_view,
> so factor out the function_view into the type alias.
>
> Change-Id: I24a1d2fc233aa5d593c9c68581a9912bfee3a348
> ---
>  gdb/ada-lang.c | 2 +-
>  gdb/language.h | 2 +-
>  gdb/linespec.c | 6 +++---
>  gdb/symtab.c   | 2 +-
>  gdb/symtab.h   | 4 ++--
>  5 files changed, 8 insertions(+), 8 deletions(-)
>

> diff --git a/gdb/symtab.h b/gdb/symtab.h
> index 3936052706f1..3217d00914ce 100644
> --- a/gdb/symtab.h
> +++ b/gdb/symtab.h
> @@ -2811,7 +2811,7 @@ std::vector<const linetable_entry *> find_linetable_entries_for_symtab_line
>     true to indicate that LA_ITERATE_OVER_SYMBOLS should continue
>     iterating, or false to indicate that the iteration should end.  */
>  
> -typedef bool (symbol_found_callback_ftype) (struct block_symbol *bsym);
> +using symbol_found_callback_ftype = gdb::function_view<bool (block_symbol *)>;

The comment on this type is very out of date, the referenced 
LA_ITERATE_OVER_SYMBOLS no longer exists.  Any by dropping the argument
name in the new type it's no longer possible to reference the argument
in the command, which is unfortunate.  Though again, the comment
previously referenced SYM when the argument was BSYM.

I know none of this is your fault, but would you mind bringing the
comment up to date please.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew