From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0dNBLiU84mnjwh4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 09:56:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dbmy1mYG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B8AB11E0C3; Fri, 17 Apr 2026 09:56:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 55E051E0B1 for ; Fri, 17 Apr 2026 09:56:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 36CB74CCCA3C for ; Fri, 17 Apr 2026 13:56:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36CB74CCCA3C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dbmy1mYG Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 160AF4C91748 for ; Fri, 17 Apr 2026 13:55:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 160AF4C91748 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 160AF4C91748 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776434155; cv=none; b=mFpoMEONBnOIJOzBdtPYEb7evOSleJzvNNjoDiX1WKzCu5edkmPQtRzsbO+ooWfJQd5iDIUe4n2V2RmLHjId2/alxiPShQq8y88AbOebsedU4tm94rNN4CDuRLdTou8zPEmLgIbzbB4cWgAmpQDRD9ABbxriFRboyOKW9H+KUvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776434155; c=relaxed/simple; bh=vDPah+lRTQthxxcAMl7OkmJ/f1FHZHKzEpAQtmWi9X4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DM6QF9HWo6vr4baJpSCRbw1NKDPtKRsyFkh728eiygfLi2kS0kJ6bL6JPozID7t12YDa9Bv1XWdqPwn587tMYgOd5UsYBCzEpVuQM2kpqdHCx+Sr5WyFniG1c7V6FYU9hMBqbbrvkbGMtQX747UbC6qZB2i5kNnM0M+Pj1qWgvw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 160AF4C91748 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776434154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HNf+9Lub6JVkuq4m1lecM5OY2gkt8pzGNuA/mt03ZpM=; b=dbmy1mYG6oq71NzWpKiwxwfEa8PNI0tyVK1HRwkl9wA6E6Au1U7TofiEOBSuVU+QOmaPLs cddWJjNDoIR9N7kjrDByLmk1YA0liRHVBsfFSu4mJh+QXOm1YROPigIZiKQ/zY4xcVP4cT cq8cs1CzaJQ9oD+psEbEaY4ycsqhUiE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-C8-yXeH_O--enKy-KbV_-w-1; Fri, 17 Apr 2026 09:55:52 -0400 X-MC-Unique: C8-yXeH_O--enKy-KbV_-w-1 X-Mimecast-MFC-AGG-ID: C8-yXeH_O--enKy-KbV_-w_1776434151 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d7730e9e3so420054f8f.2 for ; Fri, 17 Apr 2026 06:55:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776434151; x=1777038951; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HNf+9Lub6JVkuq4m1lecM5OY2gkt8pzGNuA/mt03ZpM=; b=et8qgDXdqTfYz/aCPmgmodsQczySmMW3PQP6OuevMv2cWVaq2437D0HMjmc1Pf48mL l5tkYxAjV/a1F6QhqZNna/D4+zbQ1nPuro0/YHuW+eyupb5PPItBY+v/XSKbFRLvlb2J wkCoCLKavgb7fkHzxgqywFLQ3f2sbPiZ1eN6Xd2t292FDth/2ZbshUEyWkANwL/yjCGq rRLAj1/NDkDITJANQy7wdf8pHJEVjpMCosQKyOoi1RFBz08/xgRrymPEPRQTLyFcefdM QLs2nNyjGHG5zfc8mE8HTkPzU+65idKbNHBB+lRO0r6vlCezh5FPDHoWurVM/ii4cK3G +b1A== X-Forwarded-Encrypted: i=1; AFNElJ/Jpn467Tz7uxEpkt9e+bMtXh1v+HJLNKgO4lsyD2/vA78H1stlByGpVbuGR4tPntttiC86H2WIuRoPsg==@sourceware.org X-Gm-Message-State: AOJu0YyaVkp4v0kY7iYJ6CCYRTByEjkDXFw03RPVgjv9kZDVOtcr67q3 BJPaoi19wIcPBy9cj7RbGvV8r5vAC5idjybXOSIyiTlPNwCYFFw0A3XnqIyp9S58UWoQHSoAjmE k7cCE95JjDQP5tFjm8hxlFA2wD0IYPEk5wjuLhUgBpkFIS+woemaxm26IxfhMnmY= X-Gm-Gg: AeBDieu39HvDrEdEMjcx6PwlqeJb5GcHECqzNgW+zQqv8sB9Hftgl0x+bVensu/66De qp22BeEbKTZqjWXSgxbrJLI1vUx/tBmF5fqWcLzlFgsBPU9EP2NxujyfzFfJbbexPgp/14PU7F1 8yy1+Y0Fec0OlFtUA/KuWnQe0FHmdxNpgLlsZGTfLOfSmRRvfCU+zfhKUAeIXQF+u+Y7I4Rsy/K /cBlrxIjGY6SCYjIUpFErgNOuyz/BpQCF04wCZ29nYiL2tYjKIiX1OI0XPtbTNcfrqApaMU9joM hSvWwPZ4AJRR53YGkDb/kCoJtdk4YUqL1QNFOj9Qx1tK3iTWvvg8JQisG8IfSC5rCxJb88wiEU4 tXyEvNQIS/cyBXJ2xLxzvIDgOXUY= X-Received: by 2002:a5d:5d88:0:b0:43d:7d6f:f535 with SMTP id ffacd0b85a97d-43fe3e10c0dmr4398089f8f.35.1776434151014; Fri, 17 Apr 2026 06:55:51 -0700 (PDT) X-Received: by 2002:a5d:5d88:0:b0:43d:7d6f:f535 with SMTP id ffacd0b85a97d-43fe3e10c0dmr4398045f8f.35.1776434150480; Fri, 17 Apr 2026 06:55:50 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a381sm5269032f8f.21.2026.04.17.06.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 06:55:50 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 10/11] gdb: make symbol_found_callback_ftype a function_view In-Reply-To: <20260416202408.422441-11-simon.marchi@efficios.com> References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-11-simon.marchi@efficios.com> Date: Fri, 17 Apr 2026 14:55:49 +0100 Message-ID: <875x5pelne.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ktJ5ryu49YNvAJJQ1XHjfVu9qaEOZENf4lrb7-aAOAg_1776434151 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > From: Simon Marchi > > All uses of symbol_found_callback_ftype use it within a function_view, > so factor out the function_view into the type alias. > > Change-Id: I24a1d2fc233aa5d593c9c68581a9912bfee3a348 > --- > gdb/ada-lang.c | 2 +- > gdb/language.h | 2 +- > gdb/linespec.c | 6 +++--- > gdb/symtab.c | 2 +- > gdb/symtab.h | 4 ++-- > 5 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gdb/symtab.h b/gdb/symtab.h > index 3936052706f1..3217d00914ce 100644 > --- a/gdb/symtab.h > +++ b/gdb/symtab.h > @@ -2811,7 +2811,7 @@ std::vector find_linetable_entries_for_symtab_line > true to indicate that LA_ITERATE_OVER_SYMBOLS should continue > iterating, or false to indicate that the iteration should end. */ > > -typedef bool (symbol_found_callback_ftype) (struct block_symbol *bsym); > +using symbol_found_callback_ftype = gdb::function_view; The comment on this type is very out of date, the referenced LA_ITERATE_OVER_SYMBOLS no longer exists. Any by dropping the argument name in the new type it's no longer possible to reference the argument in the command, which is unfortunate. Though again, the comment previously referenced SYM when the argument was BSYM. I know none of this is your fault, but would you mind bringing the comment up to date please. Approved-By: Andrew Burgess Thanks, Andrew