Re: [PATCH 04/11] gdb, gdbserver: make iterate_over_lwps_ftype a function_view

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simon.marchi@efficios.com> writes:

> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> All users of iterate_over_lwps_ftype use it within a function_view
> template.  Integrate function_view to the type alias.
>
> Change-Id: I3eb23aa3dbc1889072a5d4654e861b00942d6c3f
> ---
>  gdb/linux-nat.c        | 5 ++---
>  gdb/nat/linux-nat.h    | 7 +++----
>  gdbserver/linux-low.cc | 5 ++---
>  3 files changed, 7 insertions(+), 10 deletions(-)
>

> diff --git a/gdb/nat/linux-nat.h b/gdb/nat/linux-nat.h
> index 708990acc4d9..42c0467191fe 100644
> --- a/gdb/nat/linux-nat.h
> +++ b/gdb/nat/linux-nat.h
> @@ -47,7 +47,7 @@ extern tribool have_ptrace_getregset;
>  extern ptid_t current_lwp_ptid (void);
>  
>  /* Function type for the CALLBACK argument of iterate_over_lwps.  */
> -typedef int (iterate_over_lwps_ftype) (struct lwp_info *lwp);
> +using iterate_over_lwps_ftype = gdb::function_view<int (lwp_info *lwp)>;
>  
>  /* Iterate over all LWPs.  Calls CALLBACK with its second argument set
>     to DATA for every LWP in the list.  If CALLBACK returns nonzero for
> @@ -55,9 +55,8 @@ typedef int (iterate_over_lwps_ftype) (struct lwp_info *lwp);
>     LWP immediately.  Otherwise return NULL.  This function must be
>     provided by the client.  */

While looking at this change, I noticed that the comment for this
declaration is out of date.  This is NOT your fault, it became out of
date a while back.  But would you mind fixing the comment as you're also
touching the declaration?

>  
> -extern struct lwp_info *iterate_over_lwps
> -    (ptid_t filter,
> -     gdb::function_view<iterate_over_lwps_ftype> callback);
> +extern lwp_info *iterate_over_lwps (ptid_t filter,
> +				    iterate_over_lwps_ftype callback);
>  
>  /* Return the ptid of LWP.  */
>  

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew