Re: [PATCH 02/11] gdb: rename search_symtabs_expansion_listener -> compunit_symtab_iteration_callback

[Simon Marchi <simon.marchi@polymtl.ca>]

On 4/17/26 1:17 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> I think that the name search_symtabs_expansion_listener function type
> Simon> no longer makes sense for the following reasons:
> 
> Simon>  - Since we have both `symtab` and `compunit_symtab` structs, I like
> Simon>    when we are specific about which one we're talking about.  In this
> Simon>    case, the callback takes a `compunit_symtab`.
> 
> Simon>  - Following series "Search symbols via quick API" [1] last year (I
> Simon>    believe commit f88f9f42db8 ("Have expand_symtabs_matching work for
> Simon>    already-expanded CUs")), the callback gets called for all matching
> Simon>    compunit_symtabs, not just those that get expanded.
> 
> Simon> I therefore propose to rename it to compunit_symtab_iteration_callback.
> Simon> I chose "callback" over "listener", because I think that listener
> Simon> implies that there is some event happening, that we listen for.  That
> Simon> made sense before where we would listen for the "expansion" event.  But
> Simon> now since it just gets called back for all matching CUs, I think that
> Simon> "callback" makes more sense.
> 
> This seems fine to me, thanks.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, I pushed the whole series.

Simon