From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id o98lAmeL4mnMBSAAWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 15:35:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=V+ST1Ift; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E36421E0B1; Fri, 17 Apr 2026 15:35:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A54B1E04F for ; Fri, 17 Apr 2026 15:35:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 86D2C4CD203A for ; Fri, 17 Apr 2026 19:35:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86D2C4CD203A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=V+ST1Ift Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id CC0374AA3974 for ; Fri, 17 Apr 2026 19:34:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC0374AA3974 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC0374AA3974 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776454478; cv=none; b=YqmkuOomuAJUkvjHIgRwbrPyXsMu52OF0cswaEmcv9tNR9h7Vsw5MGxeDZhwKxAy/poHQtZlKJejY6HbFZLxt8NcZdNCt4n5CfQmAgAgxRqHRPrFMTkPP9xm+LUgP4Z8U4FJZrIat68dD6poHX1+bTI3AZ8hpaRg4Ktk7XG7RuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776454478; c=relaxed/simple; bh=FK46scMESB4bn6XFA4nogkql4xefA4ZUEDmlwJZq87I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=F93wvmMmFdfDH/o27yCyO4DZvwGLNigOT21FRuKy/F3dcCwFMn45yojtwZNGgoo7naVtQe6HiTfJWCuFD+YMi/SU8QKvxHRqERdbcGWwNipzX5LwXgxGaRlKowvkKKvbtn4I45/WKGJA+uklI+vW4Lwa2jC+3T77mfHxuAGYGNU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC0374AA3974 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 63HJYU9q241698 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Apr 2026 15:34:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 63HJYU9q241698 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1776454476; bh=mQriSorLtUnGEXBVcxKw0vWQ0tmbCe2Z8GfVXckXbuA=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=V+ST1Iftrz0AyusQzWzMJBsFz4nppaHKdRhLmBnUIQT5//KK+5c4RDSjox8DuDhkS 2o6uBBVRIbYFpt4cJ0DrMsjhBHIDGQKE5q6Ooq4kZWvehmCClPq1plFKCYPodKGi3X omT6l0+hxWBswY2NnnEGrnmyYGElF4e8L+D/dWowES+kuG5Yr7B/aqQ/uaKNuh5+Dj HrRsIcVof/DZDn63nQd5I7MzHKUGQ4jyoOuQmfCUq9eYpWp4UUv7cG5YadjnVfypf8 OSKGu7CKWdKo8ENih/dqTvRD8oOxJb5ecpS6ypSfkjkAOL2dGc43TExR+gveCCO9Q/ CdT1CBO9/EBKg== Received: by simark.ca (Postfix) id 7BF151E04F; Fri, 17 Apr 2026 15:34:29 -0400 (EDT) Message-ID: <83c21eb3-f95e-4ea8-af58-dde62bb97202@polymtl.ca> Date: Fri, 17 Apr 2026 15:34:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] gdb: rename search_symtabs_expansion_listener -> compunit_symtab_iteration_callback To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-3-simon.marchi@efficios.com> <87mrz1se0b.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87mrz1se0b.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 17 Apr 2026 19:34:30 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 1:17 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> From: Simon Marchi > Simon> I think that the name search_symtabs_expansion_listener function type > Simon> no longer makes sense for the following reasons: > > Simon> - Since we have both `symtab` and `compunit_symtab` structs, I like > Simon> when we are specific about which one we're talking about. In this > Simon> case, the callback takes a `compunit_symtab`. > > Simon> - Following series "Search symbols via quick API" [1] last year (I > Simon> believe commit f88f9f42db8 ("Have expand_symtabs_matching work for > Simon> already-expanded CUs")), the callback gets called for all matching > Simon> compunit_symtabs, not just those that get expanded. > > Simon> I therefore propose to rename it to compunit_symtab_iteration_callback. > Simon> I chose "callback" over "listener", because I think that listener > Simon> implies that there is some event happening, that we listen for. That > Simon> made sense before where we would listen for the "expansion" event. But > Simon> now since it just gets called back for all matching CUs, I think that > Simon> "callback" makes more sense. > > This seems fine to me, thanks. > Approved-By: Tom Tromey > > Tom Thanks, I pushed the whole series. Simon