Re: [PATCH 08/11] gdb: split iterate_over_symtabs in for_each_symtab and find_symtab

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simon.marchi@efficios.com> writes:

> Same rationale as the previous patches.
>
> For the moment, find_symtab is only needed internally in symtab.c, so
> keep it static there.  Note that the interaction with
> objfile.map_symtabs_matching_filename gets cleaner in a subsequent
> patch.
>
> for_each_symtab is implemented using find_symtab, because the iteration
> behavior is not completely trivial.
>
> find_symtab_callback_ftype is in the header file, because it is used
> from another source file in the next patch.
>
> Change-Id: I6ab8342151eb735327fc2e7935e7a65cede5e1dd
> ---
>  gdb/linespec.c |  5 ++---
>  gdb/symtab.c   | 55 ++++++++++++++++++++++++++++++++++----------------
>  gdb/symtab.h   | 19 +++++++++--------
>  3 files changed, 51 insertions(+), 28 deletions(-)
>

> diff --git a/gdb/symtab.c b/gdb/symtab.c
> index 5a39081dfc54..6a5c8c7058e4 100644
> --- a/gdb/symtab.c
> +++ b/gdb/symtab.c
> @@ -629,12 +629,16 @@ compare_filenames_for_search (const char *filename, const char *search_name)
>  	      && STRIP_DRIVE_SPEC (filename) == &filename[len - search_len]));
>  }
>  
> -/* See symtab.h.  */
> +/* Return the first symtab in PSPACE matching NAME.
>  
> -void
> -iterate_over_symtabs (program_space *pspace, const char *name,
> -		      gdb::function_view<iteration_status (symtab *)> callback)
> +   See documentation for for_each_symtab for how exactly NAME is matched.  */
> +

The comment here fails to mention CALLBACK as you have for your other
find_* functions, something like:

   Return the first symtab in PSPACE matching NAME and for which
   CALLBACK returns true.

Or similar.

> +static symtab *
> +find_symtab (program_space *pspace, const char *name,
> +	     find_symtab_callback_ftype callback)
>  {
> +  struct symtab *result = NULL;

I know this is copy & paste, but could you NULL -> nullptr please.

Otherwise:

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew