From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 67xCJRpN4ml8AR8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 11:09:14 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Ard8py4C; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 81E181E0B1; Fri, 17 Apr 2026 11:09:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03B7F1E093 for ; Fri, 17 Apr 2026 11:09:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 973DE4CCCA09 for ; Fri, 17 Apr 2026 15:09:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 973DE4CCCA09 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Ard8py4C Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 85DC64BA23DE for ; Fri, 17 Apr 2026 15:08:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85DC64BA23DE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85DC64BA23DE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776438529; cv=none; b=AqXivESJOoOLC6kNESYCnGQeSXefdCq/lbTO/soX2AySIy71GdsDHeTAmjp7XbaLqh20GoBcIROgHFYaIgmnpA5nW6gC7eghM6XjAukm0YsPnLHIDVz3qQOHMwqzgPLE2pOXApFA6Qlh36ebQ1TRCz2G2BNlFPgAvMwnTI9g/v8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776438529; c=relaxed/simple; bh=ui9uLluZbAXc2TOg7xDk/7Rg4ujEYzkzVeyHD6t6NBM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RdVaRYJdDSiYQ9GGZ5dgXXKQAf1/rTVfVcBBpyiK5zm0u8Wm84UEMHrOl7M54cnsg2REAkQkOFRj+ixgtiLqvYNSjBN8fJYdFVqR5UYX+h+ZEGhCKgkSuvHWna+9FT8dEUGW5HMylVafa6h6z22mCVPaqWgh7YZVTae040w4Shg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85DC64BA23DE Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 63HF8fnT141257 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Apr 2026 11:08:46 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 63HF8fnT141257 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1776438526; bh=wVD2HOA14ojyo9eNm2GHlldtqU9XZBgISxUFvN7nURM=; h=Date:Subject:To:From:In-Reply-To:From; b=Ard8py4CSCUWJGXo9GEvhJLA9HfVfz4dTF/6yNetC64bV1G/mqpXvUmqaI5C9goGw Jhr3A6laSIg/bvNmM+ISdboge9sWNxuX+ectsYSLaVcj83R6NtPJ3MnYFPLHQVf+Qc OrRHKmV8vT4ROYbH0w0eaCOn2GXlgX5Rp5pkLZQMvQ8vlpPRZTLR7zvXxKGZcO/acI d5GRB0fpr2HYDfEW1UE0pRb8kRJZ9nKF5crc/cTG8ih9Apcmm9quX9bdP7Uz6r2TDs kA6h8ooUQRvBFY2RVD4iOvf94bMG7igPbGkQG7LvMlUzmoXpAfB0T7KFnkiynRCT8Q 4xEmfbw/PnKUA== Received: by simark.ca (Postfix) id E5CA11E093; Fri, 17 Apr 2026 11:08:40 -0400 (EDT) Message-ID: Date: Fri, 17 Apr 2026 11:08:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] gdb: rename search_symtabs_expansion_listener -> compunit_symtab_iteration_callback To: Simon Marchi , gdb-patches@sourceware.org, Andrew Burgess References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-3-simon.marchi@efficios.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260416202408.422441-3-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 17 Apr 2026 15:08:41 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/16/26 4:16 PM, Simon Marchi wrote: > From: Simon Marchi > > I think that the name search_symtabs_expansion_listener function type > no longer makes sense for the following reasons: > > - Since we have both `symtab` and `compunit_symtab` structs, I like > when we are specific about which one we're talking about. In this > case, the callback takes a `compunit_symtab`. > > - Following series "Search symbols via quick API" [1] last year (I > believe commit f88f9f42db8 ("Have expand_symtabs_matching work for > already-expanded CUs")), the callback gets called for all matching > compunit_symtabs, not just those that get expanded. > > I therefore propose to rename it to compunit_symtab_iteration_callback. > I chose "callback" over "listener", because I think that listener > implies that there is some event happening, that we listen for. That > made sense before where we would listen for the "expansion" event. But > now since it just gets called back for all matching CUs, I think that > "callback" makes more sense. > > I renamed the parameters accordingly. > > [1] https://inbox.sourceware.org/gdb-patches/20250909-search-in-psyms-v4-0-e7ef9e3b6479@tromey.com/ > > Change-Id: Ia5a662e6d37caf8e0272424ddbbd82f05bdb5ebe Andrew, you sent Approved-Bys for all patches except this one, is it just an oversight? Simon