* [PREC]RFA: Add the 'options' to record_beneath_to_wait
@ 2009-08-21 3:53 Hui Zhu
2009-08-21 5:50 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Hui Zhu @ 2009-08-21 3:53 UTC (permalink / raw)
To: gdb-patches ml; +Cc: Michael Snyder
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
Hi,
I found that there is a new argument of to_wait -- options. But in
record_wait, it isn't put to record_beneath_to_wait.
So I make a patch for it. And I test it with testsuit in ubuntu i386 is OK.
Please help me review it.
Thanks,
Hui
prec-fix-record_wait_options.txt
2009-08-21 Hui Zhu <teawater@gmail.com>
* record.c (record_wait): Change the argument of
record_beneath_to_wait to options.
---
record.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/record.c
+++ b/record.c
@@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
{
/* This is a single step. */
return record_beneath_to_wait (record_beneath_to_wait_ops,
- ptid, status, 0);
+ ptid, status, options);
}
else
{
@@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
while (1)
{
ret = record_beneath_to_wait (record_beneath_to_wait_ops,
- ptid, status, 0);
+ ptid, status, options);
if (status->kind == TARGET_WAITKIND_STOPPED
&& status->value.sig == TARGET_SIGNAL_TRAP)
[-- Attachment #2: prec-fix-record_wait_options.txt --]
[-- Type: text/plain, Size: 650 bytes --]
---
record.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/record.c
+++ b/record.c
@@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
{
/* This is a single step. */
return record_beneath_to_wait (record_beneath_to_wait_ops,
- ptid, status, 0);
+ ptid, status, options);
}
else
{
@@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
while (1)
{
ret = record_beneath_to_wait (record_beneath_to_wait_ops,
- ptid, status, 0);
+ ptid, status, options);
if (status->kind == TARGET_WAITKIND_STOPPED
&& status->value.sig == TARGET_SIGNAL_TRAP)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PREC]RFA: Add the 'options' to record_beneath_to_wait
2009-08-21 3:53 [PREC]RFA: Add the 'options' to record_beneath_to_wait Hui Zhu
@ 2009-08-21 5:50 ` Michael Snyder
2009-08-21 6:37 ` Hui Zhu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2009-08-21 5:50 UTC (permalink / raw)
To: Hui Zhu; +Cc: gdb-patches ml
Hui Zhu wrote:
> Hi,
>
> I found that there is a new argument of to_wait -- options. But in
> record_wait, it isn't put to record_beneath_to_wait.
> So I make a patch for it. And I test it with testsuit in ubuntu i386 is OK.
>
> Please help me review it.
Looks good, please check it in.
Thanks!
> prec-fix-record_wait_options.txt
> 2009-08-21 Hui Zhu <teawater@gmail.com>
>
> * record.c (record_wait): Change the argument of
> record_beneath_to_wait to options.
>
> ---
> record.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/record.c
> +++ b/record.c
> @@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
> {
> /* This is a single step. */
> return record_beneath_to_wait (record_beneath_to_wait_ops,
> - ptid, status, 0);
> + ptid, status, options);
> }
> else
> {
> @@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
> while (1)
> {
> ret = record_beneath_to_wait (record_beneath_to_wait_ops,
> - ptid, status, 0);
> + ptid, status, options);
>
> if (status->kind == TARGET_WAITKIND_STOPPED
> && status->value.sig == TARGET_SIGNAL_TRAP)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PREC]RFA: Add the 'options' to record_beneath_to_wait
2009-08-21 5:50 ` Michael Snyder
@ 2009-08-21 6:37 ` Hui Zhu
0 siblings, 0 replies; 3+ messages in thread
From: Hui Zhu @ 2009-08-21 6:37 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches ml
On Fri, Aug 21, 2009 at 11:49, Michael Snyder<msnyder@vmware.com> wrote:
> Hui Zhu wrote:
>>
>> Hi,
>>
>> I found that there is a new argument of to_wait -- options. But in
>> record_wait, it isn't put to record_beneath_to_wait.
>> So I make a patch for it. And I test it with testsuit in ubuntu i386 is
>> OK.
>>
>> Please help me review it.
>
> Looks good, please check it in.
> Thanks!
Checked in.
Thanks,
Hui
>
>> prec-fix-record_wait_options.txt
>> 2009-08-21 Hui Zhu <teawater@gmail.com>
>>
>> * record.c (record_wait): Change the argument of
>> record_beneath_to_wait to options.
>>
>> ---
>> record.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- a/record.c
>> +++ b/record.c
>> @@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
>> {
>> /* This is a single step. */
>> return record_beneath_to_wait (record_beneath_to_wait_ops,
>> - ptid, status, 0);
>> + ptid, status, options);
>> }
>> else
>> {
>> @@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
>> while (1)
>> {
>> ret = record_beneath_to_wait (record_beneath_to_wait_ops,
>> - ptid, status, 0);
>> + ptid, status, options);
>>
>> if (status->kind == TARGET_WAITKIND_STOPPED
>> && status->value.sig == TARGET_SIGNAL_TRAP)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-21 6:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-21 3:53 [PREC]RFA: Add the 'options' to record_beneath_to_wait Hui Zhu
2009-08-21 5:50 ` Michael Snyder
2009-08-21 6:37 ` Hui Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox