From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66136-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21732 invoked by alias); 21 Aug 2009 03:53:46 -0000
Received: (qmail 21723 invoked by uid 22791); 21 Aug 2009 03:53:45 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 03:53:40 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id C0D2231002; 	Thu, 20 Aug 2009 20:53:36 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost4.vmware.com (Postfix) with ESMTP id B84E2C9A40; 	Thu, 20 Aug 2009 20:53:36 -0700 (PDT)
Message-ID: <4A8E195B.4020306@vmware.com>
Date: Fri, 21 Aug 2009 05:50:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PREC]RFA: Add the 'options' to record_beneath_to_wait
References: <daef60380908202023y3c60bd83m59d23740e06a324e@mail.gmail.com>
In-Reply-To: <daef60380908202023y3c60bd83m59d23740e06a324e@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00335.txt.bz2

Hui Zhu wrote:
> Hi,
> 
> I found that there is a new argument of to_wait -- options.  But in
> record_wait, it isn't put to record_beneath_to_wait.
> So I make a patch for it.  And I test it with testsuit in ubuntu i386 is OK.
> 
> Please help me review it.

Looks good, please check it in.
Thanks!

> prec-fix-record_wait_options.txt
> 2009-08-21  Hui Zhu  <teawater@gmail.com>
> 
> 	* record.c (record_wait): Change the argument of
> 	record_beneath_to_wait to options.
> 
> ---
>  record.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/record.c
> +++ b/record.c
> @@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
>  	{
>  	  /* This is a single step.  */
>  	  return record_beneath_to_wait (record_beneath_to_wait_ops,
> -					 ptid, status, 0);
> +					 ptid, status, options);
>  	}
>        else
>  	{
> @@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
>  	  while (1)
>  	    {
>  	      ret = record_beneath_to_wait (record_beneath_to_wait_ops,
> -					    ptid, status, 0);
> +					    ptid, status, options);
> 
>  	      if (status->kind == TARGET_WAITKIND_STOPPED
>  		  && status->value.sig == TARGET_SIGNAL_TRAP)