From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66139-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7952 invoked by alias); 21 Aug 2009 06:25:47 -0000
Received: (qmail 7934 invoked by uid 22791); 21 Aug 2009 06:25:46 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from rv-out-0708.google.com (HELO rv-out-0708.google.com) (209.85.198.241)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 06:25:41 +0000
Received: by rv-out-0708.google.com with SMTP id b17so165450rvf.48         for <gdb-patches@sourceware.org>; Thu, 20 Aug 2009 23:25:39 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.84.2 with SMTP id m2mr89361wfl.4.1250835939211; Thu, 20  	Aug 2009 23:25:39 -0700 (PDT)
In-Reply-To: <4A8E195B.4020306@vmware.com>
References: <daef60380908202023y3c60bd83m59d23740e06a324e@mail.gmail.com>  	<4A8E195B.4020306@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Fri, 21 Aug 2009 06:37:00 -0000
Message-ID: <daef60380908202325w550225a5j2e2d6dadf5e12c06@mail.gmail.com>
Subject: Re: [PREC]RFA: Add the 'options' to record_beneath_to_wait
To: Michael Snyder <msnyder@vmware.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00338.txt.bz2

On Fri, Aug 21, 2009 at 11:49, Michael Snyder<msnyder@vmware.com> wrote:
> Hui Zhu wrote:
>>
>> Hi,
>>
>> I found that there is a new argument of to_wait -- options. =A0But in
>> record_wait, it isn't put to record_beneath_to_wait.
>> So I make a patch for it. =A0And I test it with testsuit in ubuntu i386 =
is
>> OK.
>>
>> Please help me review it.
>
> Looks good, please check it in.
> Thanks!

Checked in.

Thanks,
Hui

>
>> prec-fix-record_wait_options.txt
>> 2009-08-21 =A0Hui Zhu =A0<teawater@gmail.com>
>>
>> =A0 =A0 =A0 =A0* record.c (record_wait): Change the argument of
>> =A0 =A0 =A0 =A0record_beneath_to_wait to options.
>>
>> ---
>> =A0record.c | =A0 =A04 ++--
>> =A01 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- a/record.c
>> +++ b/record.c
>> @@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
>> =A0 =A0 =A0 =A0{
>> =A0 =A0 =A0 =A0 =A0/* This is a single step. =A0*/
>> =A0 =A0 =A0 =A0 =A0return record_beneath_to_wait (record_beneath_to_wait=
_ops,
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0ptid, status, 0);
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0ptid, status, options);
>> =A0 =A0 =A0 =A0}
>> =A0 =A0 =A0 else
>> =A0 =A0 =A0 =A0{
>> @@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
>> =A0 =A0 =A0 =A0 =A0while (1)
>> =A0 =A0 =A0 =A0 =A0 =A0{
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0ret =3D record_beneath_to_wait (record_beneat=
h_to_wait_ops,
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 ptid, status, 0);
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 ptid, status, options);
>>
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0if (status->kind =3D=3D TARGET_WAITKIND_STOPP=
ED
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&& status->value.sig =3D=3D TARGET_SI=
GNAL_TRAP)
>
>