Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Cc: Michael Snyder <msnyder@vmware.com>
Subject: [PREC]RFA: Add the 'options' to record_beneath_to_wait
Date: Fri, 21 Aug 2009 03:53:00 -0000	[thread overview]
Message-ID: <daef60380908202023y3c60bd83m59d23740e06a324e@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

Hi,

I found that there is a new argument of to_wait -- options.  But in
record_wait, it isn't put to record_beneath_to_wait.
So I make a patch for it.  And I test it with testsuit in ubuntu i386 is OK.

Please help me review it.

Thanks,
Hui

prec-fix-record_wait_options.txt
2009-08-21  Hui Zhu  <teawater@gmail.com>

	* record.c (record_wait): Change the argument of
	record_beneath_to_wait to options.

---
 record.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/record.c
+++ b/record.c
@@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
 	{
 	  /* This is a single step.  */
 	  return record_beneath_to_wait (record_beneath_to_wait_ops,
-					 ptid, status, 0);
+					 ptid, status, options);
 	}
       else
 	{
@@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
 	  while (1)
 	    {
 	      ret = record_beneath_to_wait (record_beneath_to_wait_ops,
-					    ptid, status, 0);
+					    ptid, status, options);

 	      if (status->kind == TARGET_WAITKIND_STOPPED
 		  && status->value.sig == TARGET_SIGNAL_TRAP)

[-- Attachment #2: prec-fix-record_wait_options.txt --]
[-- Type: text/plain, Size: 650 bytes --]

---
 record.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/record.c
+++ b/record.c
@@ -598,7 +598,7 @@ record_wait (struct target_ops *ops,
 	{
 	  /* This is a single step.  */
 	  return record_beneath_to_wait (record_beneath_to_wait_ops,
-					 ptid, status, 0);
+					 ptid, status, options);
 	}
       else
 	{
@@ -609,7 +609,7 @@ record_wait (struct target_ops *ops,
 	  while (1)
 	    {
 	      ret = record_beneath_to_wait (record_beneath_to_wait_ops,
-					    ptid, status, 0);
+					    ptid, status, options);
 
 	      if (status->kind == TARGET_WAITKIND_STOPPED
 		  && status->value.sig == TARGET_SIGNAL_TRAP)

             reply	other threads:[~2009-08-21  3:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  3:53 Hui Zhu [this message]
2009-08-21  5:50 ` Michael Snyder
2009-08-21  6:37   ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380908202023y3c60bd83m59d23740e06a324e@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox