Re: [PATCH 1/4] gdb: remove some unnecessary code from print_gdb_hints

[Patrick Monnerat <patrick@monnerat.net>]

On 12/4/25 5:38 PM, Andrew Burgess wrote:
> I noticed some code in print_gdb_hints that is unused.  There's a
> std::string that is never used, and a 'return' that is unnecessary, we
> can just drop out of the 'if' block and return at the end of the
> function.
>
> There should be no user visible changes after this commit.
> ---
>   gdb/top.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/gdb/top.c b/gdb/top.c
> index 0798fea7a3b..27ea3d95aec 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1444,11 +1444,8 @@ print_gdb_hints (struct ui_file *stream)
>        lines, but URLs can't.  */
>     if (width - 3 <= docs_url.length ())
>       {
> -      std::string sep (width, '-');
The above line has already been removed by 
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=06e470d8fc0ae0e83fe0977fdf8c011998980891 

>         for (string_file &msg : styled_msg)
>   	gdb_printf (stream, "%s\n", msg.c_str ());
> -
> -      return;
>       }
>     else
>       {
You're right for the return :-)