Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, guinevere@redhat.com
Subject: Re: [PATCH 2/2] gdb: fix crashes and weird output from new boxed hint text
Date: Fri, 05 Dec 2025 09:06:43 +0200	[thread overview]
Message-ID: <86o6odz9to.fsf@gnu.org> (raw)
In-Reply-To: <4b43725ed933401645977e62651334d7510390a5.1764877519.git.aburgess@redhat.com> (message from Andrew Burgess on Thu, 4 Dec 2025 19:47:25 +0000)

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>,
>  Guinevere Larsen <guinevere@redhat.com>
> Date: Thu,  4 Dec 2025 19:47:25 +0000
> 
> After the commit:
> 
>   commit f6df8aa48f120b78f0670b429f8a3363020a47dc
>   Date:   Mon Sep 15 11:56:17 2025 -0300
> 
>       gdb: Make startup message more user friendly
> 
> I noticed, that when I start GDB with a file on the command line, I
> was seeing some stray '..'.  Like this:
> 
>   $ gdb -nw -nh /tmp/hello.x
>   GNU gdb (GDB) 18.0.50.20251202-git
>   Copyright (C) 2025 Free Software Foundation, Inc.
>   License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>   This is free software: you are free to change and redistribute it.
>   There is NO WARRANTY, to the extent permitted by law.
>   Type "show copying" and "show warranty" for details.
>   This GDB was configured as "x86_64-pc-linux-gnu".
>   Type "show configuration" for configuration details.
>   For bug reporting instructions, please see:
>   <https://www.gnu.org/software/gdb/bugs/>.
> 
>   ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
>   ┃ Find the GDB manual online at:                                               ┃
>   ┃ http://www.gnu.org/software/gdb/documentation/.                              ┃
>   ┃ For help, type "help".                                                       ┃
>   ┃ Type "apropos <word>" to search for commands related to <word>               ┃
>   ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
>   ..
>   Reading symbols from /tmp/hello.x...
> 
> Notice the '..' after the boxed hint text, that's what I'm complaining
> about.
> 
> Before the above commit these '..' used to appear after the line:
> 
>   Type "apropos <word>" to search for commands related to <word>
> 
> The '..' are added to show that a file is being loaded, and that this
> might take some time.  But we have the 'Reading symbols from ...' text
> to indicate this now, so I think these extra '..' are redundant.  Lets
> just drop them.

But the single period will still be there, right?  IOW, that line
will, after applying the patch, look like this:

  Type "apropos word" to search for commands related to "word".

with the single period at its end, right?  What you wrote above could
be interpreted as meaning there will be no periods at all, which IMO
would be sub-optimal, and inconsistent with the line we show before,
which says

  For help, type "help".

and correctly ends in a period.

Thanks.

  reply	other threads:[~2025-12-05  7:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 16:38 [PATCH 0/4] Fixes and tests related to new boxed hint startup text Andrew Burgess
2025-12-04 16:38 ` [PATCH 1/4] gdb: remove some unnecessary code from print_gdb_hints Andrew Burgess
2025-12-04 17:14   ` Patrick Monnerat
2025-12-04 16:38 ` [PATCH 2/4] gdb: small white space fix in print_gdb_hints Andrew Burgess
2025-12-04 16:38 ` [PATCH 3/4] gdb: make get_chars_per_line return an unsigned value Andrew Burgess
2025-12-04 16:38 ` [PATCH 4/4] gdb: fix crashes and weird output from new boxed hint text Andrew Burgess
2025-12-04 19:02 ` [PATCH 0/4] Fixes and tests related to new boxed hint startup text Guinevere Larsen
2025-12-04 19:32   ` Andrew Burgess
2025-12-04 19:47 ` [PATCH 0/2] " Andrew Burgess
2025-12-04 19:47   ` [PATCH 1/2] gdb: make get_chars_per_line return an unsigned value Andrew Burgess
2025-12-04 19:47   ` [PATCH 2/2] gdb: fix crashes and weird output from new boxed hint text Andrew Burgess
2025-12-05  7:06     ` Eli Zaretskii [this message]
2025-12-05 10:17       ` Andrew Burgess
2025-12-05 11:19         ` Eli Zaretskii
2025-12-05 19:53   ` [PATCHv3 0/3] Fixes and tests related to new boxed hint startup text Andrew Burgess
2025-12-05 19:53     ` [PATCHv3 1/3] gdb: make get_chars_per_line return an unsigned value Andrew Burgess
2025-12-10 16:48       ` Tom Tromey
2025-12-05 19:53     ` [PATCHv3 2/3] gdb: fix crashes and weird output from new boxed hint text Andrew Burgess
2025-12-10 16:51       ` Tom Tromey
2025-12-05 19:53     ` [PATCHv3 3/3] WIP: disable progress bars setting Andrew Burgess
2025-12-06  9:12       ` Eli Zaretskii
2025-12-09 17:32       ` Andrew Burgess
2025-12-10 16:55         ` Tom Tromey
2025-12-15 15:33           ` Andrew Burgess
2025-12-16  7:40       ` Tom de Vries
2025-12-16 10:05         ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o6odz9to.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox