From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv3 3/3] WIP: disable progress bars setting
Date: Wed, 10 Dec 2025 09:55:46 -0700 [thread overview]
Message-ID: <875xae2s4t.fsf@tromey.com> (raw)
In-Reply-To: <87h5tz5zn8.fsf@redhat.com> (Andrew Burgess's message of "Tue, 09 Dec 2025 17:32:59 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Now, progress bars should display correctly on any width of output
Andrew> terminal over 50 characters, the minimum required. And the debuginfod
Andrew> tests should all pass as they turn off progress bars.
Thanks. I have one nit but it's ok with this fixed.
Andrew> diff --git a/gdb/cli-out.c b/gdb/cli-out.c
Andrew> index 5aa13a64271..ae60b65064b 100644
Andrew> --- a/gdb/cli-out.c
Andrew> +++ b/gdb/cli-out.c
...]
Andrew> +INIT_GDB_FILE (cli_out)
Andrew> +{
...
Andrew> + nullptr,
Andrew> + show_progress_bars_enabled,
Andrew> + &set_progress_bars_prefix_list,
Andrew> + &show_progress_bars_prefix_list);
Andrew> +
Andrew> +
Andrew> +}
There's a couple extraneous empty lines here.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2025-12-10 16:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 16:38 [PATCH 0/4] Fixes and tests related to new boxed hint startup text Andrew Burgess
2025-12-04 16:38 ` [PATCH 1/4] gdb: remove some unnecessary code from print_gdb_hints Andrew Burgess
2025-12-04 17:14 ` Patrick Monnerat
2025-12-04 16:38 ` [PATCH 2/4] gdb: small white space fix in print_gdb_hints Andrew Burgess
2025-12-04 16:38 ` [PATCH 3/4] gdb: make get_chars_per_line return an unsigned value Andrew Burgess
2025-12-04 16:38 ` [PATCH 4/4] gdb: fix crashes and weird output from new boxed hint text Andrew Burgess
2025-12-04 19:02 ` [PATCH 0/4] Fixes and tests related to new boxed hint startup text Guinevere Larsen
2025-12-04 19:32 ` Andrew Burgess
2025-12-04 19:47 ` [PATCH 0/2] " Andrew Burgess
2025-12-04 19:47 ` [PATCH 1/2] gdb: make get_chars_per_line return an unsigned value Andrew Burgess
2025-12-04 19:47 ` [PATCH 2/2] gdb: fix crashes and weird output from new boxed hint text Andrew Burgess
2025-12-05 7:06 ` Eli Zaretskii
2025-12-05 10:17 ` Andrew Burgess
2025-12-05 11:19 ` Eli Zaretskii
2025-12-05 19:53 ` [PATCHv3 0/3] Fixes and tests related to new boxed hint startup text Andrew Burgess
2025-12-05 19:53 ` [PATCHv3 1/3] gdb: make get_chars_per_line return an unsigned value Andrew Burgess
2025-12-10 16:48 ` Tom Tromey
2025-12-05 19:53 ` [PATCHv3 2/3] gdb: fix crashes and weird output from new boxed hint text Andrew Burgess
2025-12-10 16:51 ` Tom Tromey
2025-12-05 19:53 ` [PATCHv3 3/3] WIP: disable progress bars setting Andrew Burgess
2025-12-06 9:12 ` Eli Zaretskii
2025-12-09 17:32 ` Andrew Burgess
2025-12-10 16:55 ` Tom Tromey [this message]
2025-12-15 15:33 ` Andrew Burgess
2025-12-16 7:40 ` Tom de Vries
2025-12-16 10:05 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xae2s4t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox