Re: [PATCHv3 3/3] WIP: disable progress bars setting

[Andrew Burgess <aburgess@redhat.com>]

Tom de Vries <tdevries@suse.de> writes:

> On 12/5/25 8:53 PM, Andrew Burgess wrote:
>> +file from debuginfod.  When @value{off}, @value{GDBN} will not display
>> +a progress bar.  When @value{on}, @value{GDBN} will display a progress
>
> Hi,
>
> I noticed in the build:
> ...
> gdb.texinfo:51356: warning: undefined flag: off
> gdb.texinfo:51357: warning: undefined flag: on
> ...
> and indeed in the online documentation:
> ...
> set progress-bars enabled [on|off]
>
>      Set whether GDB can display a progress bar when downloading a file 
> from debuginfod. When {No value for ‘off’}, GDB will not display a 
> progress bar. When {No value for ‘on’}, GDB will display a progress bar 
> if GDB’s output console supports it.
> ...

Sorry for that.  I pushed the patch below to resolve this problem.

Thanks,
Andrew

--

commit 9529188a184f69d804c9c1c974c51d3b3460e676
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue Dec 16 10:00:38 2025 +0000

    gdb/doc: fix incorrect use of @value
    
    In commit:
    
      commit 255a9c42709958d0925d1d0d1d39d262972fd2a6
      Date:   Fri Dec 5 11:33:29 2025 +0000
    
          gdb: new setting to disable progress bars
    
    I incorrectly used @value{on} and @value{off} to reference the on/off
    settings of a new flag.  This caused the following warnings when
    building the docs:
    
      gdb.texinfo:51356: warning: undefined flag: off
      gdb.texinfo:51357: warning: undefined flag: on
    
    Looking through the docs there seems to be a split, in some cases we
    use @code and in others we use @samp.  I'm not sure @code is correct,
    so I've switched to use @samp.  The warnings are gone after this
    patch.

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 4c012393ff4..f77fe17c81f 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -51353,8 +51353,8 @@ Debuginfod Settings
 @cindex progress bars, disabling
 @item set progress-bars enabled @r{[}on@r{|}off@r{]}
 Set whether @value{GDBN} can display a progress bar when downloading a
-file from debuginfod.  When @value{off}, @value{GDBN} will not display
-a progress bar.  When @value{on}, @value{GDBN} will display a progress
+file from debuginfod.  When @samp{off}, @value{GDBN} will not display
+a progress bar.  When @samp{on}, @value{GDBN} will display a progress
 bar if @value{GDBN}'s output console supports it.
 
 @kindex show progress-bars enabled