From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HUCyNCEvQWnKhwMAWB0awg (envelope-from ) for ; Tue, 16 Dec 2025 05:06:25 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YhB4KGZ5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C73D71E0BC; Tue, 16 Dec 2025 05:06:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D82031E048 for ; Tue, 16 Dec 2025 05:06:24 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D9A964BA2E2A for ; Tue, 16 Dec 2025 10:06:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9A964BA2E2A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YhB4KGZ5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 3623C4BA2E25 for ; Tue, 16 Dec 2025 10:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3623C4BA2E25 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3623C4BA2E25 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765879534; cv=none; b=neS1GHPIeMJJZlFtLMpxMR4hLTCevtLfW/m4EYreZYqBBhYahENPZF3WQX8oo9nlxHz5gemKxOW4PpZVdY3cA22HDT3Rvbj6F0rBRuZYCpHc7utGHOa5jLqOJCXebSk46qkpIN6YLEZEO5LEayfbuews6EUkRjLyaGCIg2i41qQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765879534; c=relaxed/simple; bh=fPQNjRepvuUl2T0f9wQRG0wGn1B61riW5NZWK7VOuvI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=h2FTIK19i64bPWDy99LFCXTH2jk7ccEZjK9Q1KrUCD/CeGmvuOBmwE/t/kRuL9alzbFoo9rt8hkC/4NicbnqWnImKmj192d2u5i1syxwbKeVCxCC72gQMlJ5xgRwRywPV6Ug+cao008q6uuVKerLoIefiXdBmYKRSe5m7IWfVFg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3623C4BA2E25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765879533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bawUivatC4YAtuviLCXlwiQpdXVa+1yNljMoeF92ljk=; b=YhB4KGZ52ACbXUTrpG2K2uOOFngfDjbsgwdkdVYwW+8ePsOKU6YBQOTAeTfiAv214J6guZ MUrodr10ycyFQw2luSkc/sBlEXVdcRrZ1VDryczhyWoa0sJxFwaCfIdrR0IGfLB08lhg75 c1UOBSY2hvhW56nd6iA1T6r1ATdzCqE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-vWIlMrndPlSl_3HJOlwpUw-1; Tue, 16 Dec 2025 05:05:30 -0500 X-MC-Unique: vWIlMrndPlSl_3HJOlwpUw-1 X-Mimecast-MFC-AGG-ID: vWIlMrndPlSl_3HJOlwpUw_1765879529 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47910af0c8bso33492595e9.2 for ; Tue, 16 Dec 2025 02:05:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765879529; x=1766484329; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+3jLIjM33KBCdY3ORBo2BEd8aOUNKM53dqDvQETwueM=; b=G6yG8G2tf4CFhCEyE2YK4xNNE2pFF9yi4W/TSq+t4d4QD35gzk9AAst0o+XEytNlp+ 8/brH38fKvGoPKFXkmkwDZUzEJcMK6BB6WQuB9TnxInhFysVKMw0hNv2Qu04sYL6oYu6 mciLaySwnL0dXOPraLYJRkYHqsZmseT0d/meJl8Aen8pg+wnEktGO3mEZ5OA5j6fd7gB k+qm93uqa1FJD9ayYMrs+SJVL2Xv1F4DWC/yzEsp5eQ0y7lsQo+HBlC26TBAG3zEgiLF JT5epWEMVoxbsZpraJrEVmpUstljQdXOeIG4zPmJHsRgo+kLkDJRmnOJ9Gg/Kl+qv5o4 IhNQ== X-Forwarded-Encrypted: i=1; AJvYcCVvXqp1WIZTjDjznlUxf1GjT7lgnn6V9lRFEpPixIrALr7E1hlwsTLjBuagYh4k7ieoTxNbQ2YaOSqrmw==@sourceware.org X-Gm-Message-State: AOJu0Yx8UsIAVIV4Yc6eqIt+3sZCIMpOE6I8Z3QDP1taY9EkNxygzegD jjeltejRTCgaYU/Ky49wkXHjdrNTBhIQf5JpKAWkwI1MOVJbiSG8oBqr8nTezK6PLfVp2uycOU4 G0jDkqemrKErPwIXAwreyCQV//FjbVcG1uSLK255tSz1jrcN+BJj22Crur5+z61M= X-Gm-Gg: AY/fxX61227eHaji80X8d7q2DKJ/SDz2BE7cfy+syyk/6s0YXnG39o2Vh4iA0220hPw HbKVp+UhzLFMQb/hvnePpF324HKVVLtBz1gD8gMzK4SBxkQWEFdt7QcVWbYjjtgQC5sYDSKKJ4h 5KFszb3+fW4U2dN8Aq5I8KLoiGJSipdD1vDnEgm9xfyssFRqIT8dMsjSbde01L04c5fmbq68Upv /H/h0HlwCfHAYbX6hbPG+5dvd4nq9j6N+VH8+CVYz6AktlnwpdGHr87uhaliCwDZBIUA+FfOE0B TVoX6k5aJcIHCgoCEcS0OWo8bL7MM158nrOc1+f+oC8stNYKuhklu73lYo5IWFoAfzna8i8/NcF sfP49 X-Received: by 2002:a05:600c:468c:b0:477:7f4a:44b0 with SMTP id 5b1f17b1804b1-47a8f9142bcmr153100255e9.33.1765879529026; Tue, 16 Dec 2025 02:05:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTTcNbl6vMqX9z05tYKTSwrpyGedZCM61TXHXuBgZmmAvE+lWlBB22A8vOPu52/+MIKcLB1A== X-Received: by 2002:a05:600c:468c:b0:477:7f4a:44b0 with SMTP id 5b1f17b1804b1-47a8f9142bcmr153099955e9.33.1765879528577; Tue, 16 Dec 2025 02:05:28 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f4ace61sm230694565e9.7.2025.12.16.02.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 02:05:28 -0800 (PST) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Cc: Eli Zaretskii Subject: Re: [PATCHv3 3/3] WIP: disable progress bars setting In-Reply-To: <8b7e71ed-3139-442e-b46d-d96c18e8351b@suse.de> References: <32f0ffdfd85e7a3d62a2dc3a7b06b01275412920.1764964133.git.aburgess@redhat.com> <8b7e71ed-3139-442e-b46d-d96c18e8351b@suse.de> Date: Tue, 16 Dec 2025 10:05:27 +0000 Message-ID: <87wm2m4u8o.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -h2CcsXaX00JICaOxeJYtktRWlUyG3MQXVKgMYOycoQ_1765879529 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > On 12/5/25 8:53 PM, Andrew Burgess wrote: >> +file from debuginfod. When @value{off}, @value{GDBN} will not display >> +a progress bar. When @value{on}, @value{GDBN} will display a progress > > Hi, > > I noticed in the build: > ... > gdb.texinfo:51356: warning: undefined flag: off > gdb.texinfo:51357: warning: undefined flag: on > ... > and indeed in the online documentation: > ... > set progress-bars enabled [on|off] > > Set whether GDB can display a progress bar when downloading a file= =20 > from debuginfod. When {No value for =E2=80=98off=E2=80=99}, GDB will not = display a=20 > progress bar. When {No value for =E2=80=98on=E2=80=99}, GDB will display = a progress bar=20 > if GDB=E2=80=99s output console supports it. > ... Sorry for that. I pushed the patch below to resolve this problem. Thanks, Andrew -- commit 9529188a184f69d804c9c1c974c51d3b3460e676 Author: Andrew Burgess Date: Tue Dec 16 10:00:38 2025 +0000 gdb/doc: fix incorrect use of @value =20 In commit: =20 commit 255a9c42709958d0925d1d0d1d39d262972fd2a6 Date: Fri Dec 5 11:33:29 2025 +0000 =20 gdb: new setting to disable progress bars =20 I incorrectly used @value{on} and @value{off} to reference the on/off settings of a new flag. This caused the following warnings when building the docs: =20 gdb.texinfo:51356: warning: undefined flag: off gdb.texinfo:51357: warning: undefined flag: on =20 Looking through the docs there seems to be a split, in some cases we use @code and in others we use @samp. I'm not sure @code is correct, so I've switched to use @samp. The warnings are gone after this patch. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 4c012393ff4..f77fe17c81f 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -51353,8 +51353,8 @@ Debuginfod Settings @cindex progress bars, disabling @item set progress-bars enabled @r{[}on@r{|}off@r{]} Set whether @value{GDBN} can display a progress bar when downloading a -file from debuginfod. When @value{off}, @value{GDBN} will not display -a progress bar. When @value{on}, @value{GDBN} will display a progress +file from debuginfod. When @samp{off}, @value{GDBN} will not display +a progress bar. When @samp{on}, @value{GDBN} will display a progress bar if @value{GDBN}'s output console supports it. =20 @kindex show progress-bars enabled