Re: [PATCH 2/2] gdb: fix crashes and weird output from new boxed hint text

[Andrew Burgess <aburgess@redhat.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrew Burgess <aburgess@redhat.com>
>> Cc: Andrew Burgess <aburgess@redhat.com>,
>>  Guinevere Larsen <guinevere@redhat.com>
>> Date: Thu,  4 Dec 2025 19:47:25 +0000
>> 
>> After the commit:
>> 
>>   commit f6df8aa48f120b78f0670b429f8a3363020a47dc
>>   Date:   Mon Sep 15 11:56:17 2025 -0300
>> 
>>       gdb: Make startup message more user friendly
>> 
>> I noticed, that when I start GDB with a file on the command line, I
>> was seeing some stray '..'.  Like this:
>> 
>>   $ gdb -nw -nh /tmp/hello.x
>>   GNU gdb (GDB) 18.0.50.20251202-git
>>   Copyright (C) 2025 Free Software Foundation, Inc.
>>   License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>>   This is free software: you are free to change and redistribute it.
>>   There is NO WARRANTY, to the extent permitted by law.
>>   Type "show copying" and "show warranty" for details.
>>   This GDB was configured as "x86_64-pc-linux-gnu".
>>   Type "show configuration" for configuration details.
>>   For bug reporting instructions, please see:
>>   <https://www.gnu.org/software/gdb/bugs/>.
>> 
>>   ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
>>   ┃ Find the GDB manual online at:                                               ┃
>>   ┃ http://www.gnu.org/software/gdb/documentation/.                              ┃
>>   ┃ For help, type "help".                                                       ┃
>>   ┃ Type "apropos <word>" to search for commands related to <word>               ┃
>>   ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
>>   ..
>>   Reading symbols from /tmp/hello.x...
>> 
>> Notice the '..' after the boxed hint text, that's what I'm complaining
>> about.
>> 
>> Before the above commit these '..' used to appear after the line:
>> 
>>   Type "apropos <word>" to search for commands related to <word>
>> 
>> The '..' are added to show that a file is being loaded, and that this
>> might take some time.  But we have the 'Reading symbols from ...' text
>> to indicate this now, so I think these extra '..' are redundant.  Lets
>> just drop them.
>
> But the single period will still be there, right?  IOW, that line
> will, after applying the patch, look like this:
>
>   Type "apropos word" to search for commands related to "word".
>
> with the single period at its end, right?  What you wrote above could
> be interpreted as meaning there will be no periods at all, which IMO
> would be sub-optimal, and inconsistent with the line we show before,
> which says
>
>   For help, type "help".
>
> and correctly ends in a period.

Yes, I'm adding the period back.  The next part of the commit message
says:

 Looking at these I noticed that the line:
 
   Type "apropos <word>" to search for commands related to <word>
 
 is missing a period at the end, so I've added that in too.

I'll reword these two parts of the commit message to make it clearer
that I'm removing the stray '..' and adding a single '.' that is missing
from the line in question.

The final result looks like this:

   ... snip ...
   <https://www.gnu.org/software/gdb/bugs/>.
 
   ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
   ┃ Find the GDB manual online at:                                               ┃
   ┃ http://www.gnu.org/software/gdb/documentation/.                              ┃
   ┃ For help, type "help".                                                       ┃
   ┃ Type "apropos <word>" to search for commands related to <word>.              ┃
   ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

   Reading symbols from /tmp/hello.x...
   (gdb)

Thanks,
Andrew