From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bnW5BuXBMWm9TRkAWB0awg (envelope-from ) for ; Thu, 04 Dec 2025 12:16:21 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=monnerat.net header.i=@monnerat.net header.a=rsa-sha256 header.s=mnet header.b=sThwCkY5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0BCBD1E08D; Thu, 04 Dec 2025 12:16:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 830E21E08D for ; Thu, 04 Dec 2025 12:16:20 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF7B74B1A366 for ; Thu, 4 Dec 2025 17:16:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF7B74B1A366 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=monnerat.net header.i=@monnerat.net header.a=rsa-sha256 header.s=mnet header.b=sThwCkY5 Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id C65C44B9DB68 for ; Thu, 4 Dec 2025 17:15:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C65C44B9DB68 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=monnerat.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=monnerat.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C65C44B9DB68 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=46.226.111.226 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764868554; cv=none; b=n5cudi5kw+gxmA94JypkSQX1QFFFWvKS8O9DaGsqzVHcJYKHM5h4inedEHSdFtZStH7Wvh2FJgJb7l3q7lRO9v3pYypSA3c6dYh/rQiiZR9dJDAv7mnwYeVh5fzQk/BXmtwOf3IVkJNwtIzfs9zbi6LUQGym3soGDsI+4aP4G2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764868554; c=relaxed/simple; bh=R0AeFaEpLhWPfgH6wwPV+N0Mb5wgqo/A9jJopH8bBBM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AH2ecrKWcb7H1NZTvV8GYXshciNxb0EYrbleAidy3Qy8sZ0r5Z7hrrJae/fgDRp1wT1szwXej7O8D1NdubmOUCct5pnPJIVr4/LxXgfg9Ez2x+Bes95juPAfJeTBqtfQt08OSXAYDVmq78QYo4yOYgH+cbergw2GCGyy0CWJZmg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C65C44B9DB68 Received: from [192.168.0.128] ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 5B4HEnQq015565 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 4 Dec 2025 18:15:52 +0100 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 5B4HEnQq015565 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=monnerat.net; s=mnet; t=1764868552; bh=R0AeFaEpLhWPfgH6wwPV+N0Mb5wgqo/A9jJopH8bBBM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=sThwCkY50l6hRGTmyBiqLtAg8wtqR60AQbbDcu2p2iAl6CuprK4YfTS9o5xe3Wv3L QmT7koVUpwBHHgVQqJyzsXiVBW6mATpYizfVsAHisCFHEinly+vUdb3e08coTnHe1y JcIMV8cmmokusSnSjXwB2lacHkkSxlGq9dn5yHjQ= Message-ID: Date: Thu, 4 Dec 2025 18:14:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] gdb: remove some unnecessary code from print_gdb_hints To: gdb-patches@sourceware.org References: <93ed8d79f824668677c77ab2f477b621b843be53.1764866150.git.aburgess@redhat.com> Content-Language: en-US From: Patrick Monnerat In-Reply-To: <93ed8d79f824668677c77ab2f477b621b843be53.1764866150.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/4/25 5:38 PM, Andrew Burgess wrote: > I noticed some code in print_gdb_hints that is unused. There's a > std::string that is never used, and a 'return' that is unnecessary, we > can just drop out of the 'if' block and return at the end of the > function. > > There should be no user visible changes after this commit. > --- > gdb/top.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gdb/top.c b/gdb/top.c > index 0798fea7a3b..27ea3d95aec 100644 > --- a/gdb/top.c > +++ b/gdb/top.c > @@ -1444,11 +1444,8 @@ print_gdb_hints (struct ui_file *stream) > lines, but URLs can't. */ > if (width - 3 <= docs_url.length ()) > { > - std::string sep (width, '-'); The above line has already been removed by https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=06e470d8fc0ae0e83fe0977fdf8c011998980891 > for (string_file &msg : styled_msg) > gdb_printf (stream, "%s\n", msg.c_str ()); > - > - return; > } > else > { You're right for the return :-)