[committed][gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

[ was: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp ]
On 11/27/21 1:59 AM, Simon Marchi wrote:
> On 2021-11-26 13:47, Simon Marchi wrote:
>>>> I'm not a fan of having a file with the generic name "main.c" there.
>>>
>>> Could you explain why not?
>>>
>>> I don't understand why we'd need to duplicate a file that can easily be
>>> reused.  It even helps one to recognize quickly (once you known the
>>> contents of the file) that the test-case that is being investigated does
>>> not require a specific executable, just based on the fact it uses "main.c".
>>
>> I usually don't like multiple test cases re-using the same source file,
>> that makes it more complicated to modify it (must make sure to not
>> change the behavior of the the other tests).  But the case of an empty
>> program is simple enough, and your reasoning makes sense, so I'm ok with
>> that.
>>
>> Simon
>>
> 
> I'm seeing these 2 failures starting from this commit:
> 
> FAIL: gdb.base/list-missing-source.exp: list
> FAIL: gdb.base/list-missing-source.exp: info source

Thanks for letting me know, fixed in commit below.

- Tom



[-- Attachment #2: 0001-gdb-testsuite-Fix-FAIL-in-gdb.base-list-missing-source.exp.patch --]
[-- Type: text/x-patch, Size: 1093 bytes --]

[gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp

In commit f8080fb7a44 "[gdb/testsuite] Add gdb.base/include-main.exp" a
file gdb.base/main.c was added, which caused the following regression:
...
(gdb) list^M
<gdb.base/main.c>
(gdb) FAIL: gdb.base/list-missing-source.exp: list
...

The problem is that the test-case does not expect to find a file main.c, but
now it finds gdb.base/main.c.

Fix this by using the more specific file name list-missing-source.c.

Tested on x86_64-linux.

---
 gdb/testsuite/gdb.base/list-missing-source.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/list-missing-source.exp b/gdb/testsuite/gdb.base/list-missing-source.exp
index d6677fc0a5e..260ba4dcb7d 100644
--- a/gdb/testsuite/gdb.base/list-missing-source.exp
+++ b/gdb/testsuite/gdb.base/list-missing-source.exp
@@ -19,7 +19,7 @@
 standard_testfile
 
 # Create a source file in the output directory.
-set srcfile [standard_output_file main.c]
+set srcfile [standard_output_file list-missing-source.c]
 set fd [open "$srcfile" w]
 puts $fd {
 int