Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-11-26 13:47, Simon Marchi wrote:
>>> I'm not a fan of having a file with the generic name "main.c" there.
>>
>> Could you explain why not?
>>
>> I don't understand why we'd need to duplicate a file that can easily be
>> reused.  It even helps one to recognize quickly (once you known the
>> contents of the file) that the test-case that is being investigated does
>> not require a specific executable, just based on the fact it uses "main.c".
> 
> I usually don't like multiple test cases re-using the same source file,
> that makes it more complicated to modify it (must make sure to not
> change the behavior of the the other tests).  But the case of an empty
> program is simple enough, and your reasoning makes sense, so I'm ok with
> that.
> 
> Simon
> 

I'm seeing these 2 failures starting from this commit:

FAIL: gdb.base/list-missing-source.exp: list
FAIL: gdb.base/list-missing-source.exp: info source

Simon