Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp
Date: Tue, 30 Nov 2021 13:39:57 -0700	[thread overview]
Message-ID: <87ilw98jj6.fsf@tromey.com> (raw)
In-Reply-To: <20211126094852.32283-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 26 Nov 2021 10:48:52 +0100")

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> Add a C test-case that mimics gdb.ada/dgopt.exp, that is:
Tom> - generate debug info as described above,
Tom> - issue a list of a line in include-main.c, while the corresponding
Tom>   CU is not expanded yet.

I noted this in another patch submission, but I thought I'd point it out
here: this test case also fails for me, with git gdb, with the fission
and fission-dwp target boards.  I'm using the Fedora 34 system gcc.

E.g.:

    $ runtest --target_board=fission gdb.base/include-main.exp
    [...]
    Running /home/tromey/gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/include-main.exp ...
    FAIL: gdb.base/include-main.exp: list include-main.c:18

Given this, I wonder if we really want to continue supporting this.  I
think it may be better to just declare these as compiler bugs (including
gdb.ada/dgopt.exp) when using fission.

The rationale for this is just that the line table and the CU DIE ought
to agree, and if they don't, GDB can just declare that it respects the
line table and may ignore the CU DIE.

What do you think of this?

Fixing this in the fission case is a pain because the GDB index is
intentionally set up to avoid reading the CU DIE unless the CU is going
to be expanded.

thanks,
Tom

  parent reply	other threads:[~2021-11-30 20:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  9:48 Tom de Vries via Gdb-patches
2021-11-26 16:20 ` Simon Marchi
2021-11-26 17:11   ` Tom de Vries via Gdb-patches
2021-11-26 18:47     ` Simon Marchi
2021-11-27  0:59       ` Simon Marchi via Gdb-patches
2021-11-27  6:12         ` [committed][gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp Tom de Vries via Gdb-patches
2021-11-30 20:39 ` Tom Tromey [this message]
2021-12-01  1:10   ` [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp Tom Tromey
2021-12-01 14:58     ` Tom de Vries via Gdb-patches
2021-12-01 17:27       ` Tom Tromey
2021-12-02 12:59         ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilw98jj6.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox