Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp
Date: Wed, 01 Dec 2021 10:27:16 -0700	[thread overview]
Message-ID: <87fsrc6xsb.fsf@tromey.com> (raw)
In-Reply-To: <4e9e03b7-170f-4493-cd7e-0759357b8a43@suse.de> (Tom de Vries's message of "Wed, 1 Dec 2021 15:58:36 +0100")

> Given this, I wonder if we really want to continue supporting this.  I
> think it may be better to just declare these as compiler bugs (including
> gdb.ada/dgopt.exp) when using fission.

Tom> I still don't understand what specific compiler behavior you consider a bug.

The file name in the CU DIE does not appear in the line table.

Tom> FYI, I've now debugged the fission failure of include-main.exp on trunk,
Tom> and found that it's because dw2_get_file_names uses a cutu reader
Tom> constructor that ignores the dwo file.  By using the other constructor,
Tom> the test passes:

I considered this, but when I looked, the .dwo file did not include the
DW_AT_stmt_list.  So, I thought this would introduce other problems.

If this can work, then I think this is the only use of this constructor
and so it could be removed.

Tom

  reply	other threads:[~2021-12-02  7:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  9:48 Tom de Vries via Gdb-patches
2021-11-26 16:20 ` Simon Marchi
2021-11-26 17:11   ` Tom de Vries via Gdb-patches
2021-11-26 18:47     ` Simon Marchi
2021-11-27  0:59       ` Simon Marchi via Gdb-patches
2021-11-27  6:12         ` [committed][gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp Tom de Vries via Gdb-patches
2021-11-30 20:39 ` [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp Tom Tromey
2021-12-01  1:10   ` Tom Tromey
2021-12-01 14:58     ` Tom de Vries via Gdb-patches
2021-12-01 17:27       ` Tom Tromey [this message]
2021-12-02 12:59         ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsrc6xsb.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox