From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp
Date: Fri, 26 Nov 2021 13:47:57 -0500 [thread overview]
Message-ID: <26a88ace-dd10-4051-43e5-db9e4308dc1d@simark.ca> (raw)
In-Reply-To: <1e731166-3636-e537-b063-d4b1deb92645@suse.de>
>> I'm not a fan of having a file with the generic name "main.c" there.
>
> Could you explain why not?
>
> I don't understand why we'd need to duplicate a file that can easily be
> reused. It even helps one to recognize quickly (once you known the
> contents of the file) that the test-case that is being investigated does
> not require a specific executable, just based on the fact it uses "main.c".
I usually don't like multiple test cases re-using the same source file,
that makes it more complicated to modify it (must make sure to not
change the behavior of the the other tests). But the case of an empty
program is simple enough, and your reasoning makes sense, so I'm ok with
that.
Simon
next prev parent reply other threads:[~2021-11-26 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 9:48 Tom de Vries via Gdb-patches
2021-11-26 16:20 ` Simon Marchi
2021-11-26 17:11 ` Tom de Vries via Gdb-patches
2021-11-26 18:47 ` Simon Marchi [this message]
2021-11-27 0:59 ` Simon Marchi via Gdb-patches
2021-11-27 6:12 ` [committed][gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp Tom de Vries via Gdb-patches
2021-11-30 20:39 ` [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp Tom Tromey
2021-12-01 1:10 ` Tom Tromey
2021-12-01 14:58 ` Tom de Vries via Gdb-patches
2021-12-01 17:27 ` Tom Tromey
2021-12-02 12:59 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a88ace-dd10-4051-43e5-db9e4308dc1d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox