Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

On 12/1/21 2:10 AM, Tom Tromey wrote:
> Tom> Given this, I wonder if we really want to continue supporting this.  I
> Tom> think it may be better to just declare these as compiler bugs (including
> Tom> gdb.ada/dgopt.exp) when using fission.
> 

I still don't understand what specific compiler behavior you consider a bug.

> Well, it so happens that my patches fix the dgopt.exp fission cases with
> my branch (but not the include-main.exp fission cases).  I was thinking
> maybe I'd be able to drop these patches, but they're also needed for
> plain include-main.exp on the branch.  So I think we can just carry on
> as-is, since I don't think the new reader will regress anything now, and
> the new patches aren't really that intrusive.

OK, that sounds good :)

FYI, I've now debugged the fission failure of include-main.exp on trunk,
and found that it's because dw2_get_file_names uses a cutu reader
constructor that ignores the dwo file.  By using the other constructor,
the test passes:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 57538fc0adf..04c258d1aef 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -3084,7 +3084,7 @@ dw2_get_file_names (dwarf2_per_cu_data *this_cu,
   if (this_cu->v.quick->files_read)
     return this_cu->v.quick->file_names;

-  cutu_reader reader (this_cu, per_objfile);
+  cutu_reader reader (this_cu, per_objfile, nullptr, nullptr, false);
   if (!reader.dummy_p)
     dw2_get_file_names_reader (&reader, reader.comp_unit_die);

...

I'm testing this currently.

Thanks,
- Tom