From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id e2vLFbKNp2EFGgAAWB0awg (envelope-from ) for ; Wed, 01 Dec 2021 09:58:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 4889B1F0CE; Wed, 1 Dec 2021 09:58:58 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB24D1ECEB for ; Wed, 1 Dec 2021 09:58:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25868385841D for ; Wed, 1 Dec 2021 14:58:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25868385841D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638370737; bh=Y0zZ4qHgRbKcBL4NVL25GyZc3f/pPR5NpfPn2ZIw54E=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p3gUsS1iVtdoL/oBUKmW5kvZWONjHZRtBs17yc82FTdMr6Ir7/o71dB9ysOfoS5xg y7vLY1QgcTZjqNLeffxuGlmtfYhIC3as8qzW3Wh8erJNgQVliPTP48bh1z3IohA9Bi e1SNMuA9UrO957KFrk3oPNigifqpQ3osZInZTW8o= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id DAFE73858C60 for ; Wed, 1 Dec 2021 14:58:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DAFE73858C60 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C02E51FD5A; Wed, 1 Dec 2021 14:58:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AAAE713D1A; Wed, 1 Dec 2021 14:58:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MxJvKJyNp2HzbwAAMHmgww (envelope-from ); Wed, 01 Dec 2021 14:58:36 +0000 Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp To: Tom Tromey References: <20211126094852.32283-1-tdevries@suse.de> <87ilw98jj6.fsf@tromey.com> <87k0gpuo30.fsf@tromey.com> Message-ID: <4e9e03b7-170f-4493-cd7e-0759357b8a43@suse.de> Date: Wed, 1 Dec 2021 15:58:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87k0gpuo30.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Tom de Vries via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 12/1/21 2:10 AM, Tom Tromey wrote: > Tom> Given this, I wonder if we really want to continue supporting this. I > Tom> think it may be better to just declare these as compiler bugs (including > Tom> gdb.ada/dgopt.exp) when using fission. > I still don't understand what specific compiler behavior you consider a bug. > Well, it so happens that my patches fix the dgopt.exp fission cases with > my branch (but not the include-main.exp fission cases). I was thinking > maybe I'd be able to drop these patches, but they're also needed for > plain include-main.exp on the branch. So I think we can just carry on > as-is, since I don't think the new reader will regress anything now, and > the new patches aren't really that intrusive. OK, that sounds good :) FYI, I've now debugged the fission failure of include-main.exp on trunk, and found that it's because dw2_get_file_names uses a cutu reader constructor that ignores the dwo file. By using the other constructor, the test passes: ... diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 57538fc0adf..04c258d1aef 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -3084,7 +3084,7 @@ dw2_get_file_names (dwarf2_per_cu_data *this_cu, if (this_cu->v.quick->files_read) return this_cu->v.quick->file_names; - cutu_reader reader (this_cu, per_objfile); + cutu_reader reader (this_cu, per_objfile, nullptr, nullptr, false); if (!reader.dummy_p) dw2_get_file_names_reader (&reader, reader.comp_unit_die); ... I'm testing this currently. Thanks, - Tom