From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lxBzMC2MpmE4dAAAWB0awg (envelope-from ) for ; Tue, 30 Nov 2021 15:40:13 -0500 Received: by simark.ca (Postfix, from userid 112) id B640B1F0CE; Tue, 30 Nov 2021 15:40:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D07F1ECEB for ; Tue, 30 Nov 2021 15:40:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAFDA385B83E for ; Tue, 30 Nov 2021 20:40:11 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.59]) by sourceware.org (Postfix) with ESMTPS id 742F03858D3C for ; Tue, 30 Nov 2021 20:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 742F03858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id ED4B49AA4 for ; Tue, 30 Nov 2021 14:39:58 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id s9uwmZBwonUhfs9uwmgm4f; Tue, 30 Nov 2021 14:39:58 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xSPd24+al9le3LCI6H4VLTrkbJtA7T8bg6A5o2aJzlI=; b=bix5dSTcCdTd26qYukZ2QFS1qM cZoG6iDnTU578aPJS7Uk+Dp65AP9j+qMYO3h2fh05iMZsSrdPZk47xA8pEn75Tu/7Jd5WDybZ+Qlo szQzd4BeDJVyUVVGvGuesWhTu; Received: from 97-122-84-67.hlrn.qwest.net ([97.122.84.67]:54224 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ms9uw-003nmq-K7; Tue, 30 Nov 2021 13:39:58 -0700 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp References: <20211126094852.32283-1-tdevries@suse.de> X-Attribution: Tom Date: Tue, 30 Nov 2021 13:39:57 -0700 In-Reply-To: <20211126094852.32283-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 26 Nov 2021 10:48:52 +0100") Message-ID: <87ilw98jj6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.84.67 X-Source-L: No X-Exim-ID: 1ms9uw-003nmq-K7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-84-67.hlrn.qwest.net (murgatroyd) [97.122.84.67]:54224 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Add a C test-case that mimics gdb.ada/dgopt.exp, that is: Tom> - generate debug info as described above, Tom> - issue a list of a line in include-main.c, while the corresponding Tom> CU is not expanded yet. I noted this in another patch submission, but I thought I'd point it out here: this test case also fails for me, with git gdb, with the fission and fission-dwp target boards. I'm using the Fedora 34 system gcc. E.g.: $ runtest --target_board=fission gdb.base/include-main.exp [...] Running /home/tromey/gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/include-main.exp ... FAIL: gdb.base/include-main.exp: list include-main.c:18 Given this, I wonder if we really want to continue supporting this. I think it may be better to just declare these as compiler bugs (including gdb.ada/dgopt.exp) when using fission. The rationale for this is just that the line table and the CU DIE ought to agree, and if they don't, GDB can just declare that it respects the line table and may ignore the CU DIE. What do you think of this? Fixing this in the fission case is a pain because the GDB index is intentionally set up to avoid reading the CU DIE unless the CU is going to be expanded. thanks, Tom