From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0Iw/GG/MoWF2VwAAWB0awg (envelope-from ) for ; Sat, 27 Nov 2021 01:13:03 -0500 Received: by simark.ca (Postfix, from userid 112) id 60B291F0CE; Sat, 27 Nov 2021 01:13:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 957721ECEB for ; Sat, 27 Nov 2021 01:13:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FE093857C5D for ; Sat, 27 Nov 2021 06:13:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FE093857C5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637993581; bh=AUEkkDeHBG4Z4DUwJn12/9EWV7oyX85GB//drkXY/ts=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IMJf7Clz3/SUvS4VUH9RF/foiasgtC0fyGD1S6gY5bnOvwlxFsnrKXnD8d1N2JX3D lDvTd+yhUQLR8wU9fzWLta0ceNI0LBa0LZqCNs7K1yoDBsquF6bxooMBOn6VGrMnGt K8vMpFoE76w9zTQataU0zXZbNnuw/rj/IOS725SU= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id E5D043858D39 for ; Sat, 27 Nov 2021 06:12:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E5D043858D39 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E57731FC9E; Sat, 27 Nov 2021 06:12:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB9A8139ED; Sat, 27 Nov 2021 06:12:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wsfVK1nMoWFIfQAAMHmgww (envelope-from ); Sat, 27 Nov 2021 06:12:41 +0000 Subject: [committed][gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20211126094852.32283-1-tdevries@suse.de> <1e731166-3636-e537-b063-d4b1deb92645@suse.de> <26a88ace-dd10-4051-43e5-db9e4308dc1d@simark.ca> <6b55cdda-832d-1db3-8291-17f2c004434a@polymtl.ca> Message-ID: Date: Sat, 27 Nov 2021 07:12:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <6b55cdda-832d-1db3-8291-17f2c004434a@polymtl.ca> Content-Type: multipart/mixed; boundary="------------CF1D90C581F1052080296DB0" Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------CF1D90C581F1052080296DB0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit [ was: Re: [PATCH] [gdb/testsuite] Add gdb.base/include-main.exp ] On 11/27/21 1:59 AM, Simon Marchi wrote: > On 2021-11-26 13:47, Simon Marchi wrote: >>>> I'm not a fan of having a file with the generic name "main.c" there. >>> >>> Could you explain why not? >>> >>> I don't understand why we'd need to duplicate a file that can easily be >>> reused. It even helps one to recognize quickly (once you known the >>> contents of the file) that the test-case that is being investigated does >>> not require a specific executable, just based on the fact it uses "main.c". >> >> I usually don't like multiple test cases re-using the same source file, >> that makes it more complicated to modify it (must make sure to not >> change the behavior of the the other tests). But the case of an empty >> program is simple enough, and your reasoning makes sense, so I'm ok with >> that. >> >> Simon >> > > I'm seeing these 2 failures starting from this commit: > > FAIL: gdb.base/list-missing-source.exp: list > FAIL: gdb.base/list-missing-source.exp: info source Thanks for letting me know, fixed in commit below. - Tom --------------CF1D90C581F1052080296DB0 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Fix-FAIL-in-gdb.base-list-missing-source.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Fix-FAIL-in-gdb.base-list-missing-source."; filename*1="exp.patch" [gdb/testsuite] Fix FAIL in gdb.base/list-missing-source.exp In commit f8080fb7a44 "[gdb/testsuite] Add gdb.base/include-main.exp" a file gdb.base/main.c was added, which caused the following regression: ... (gdb) list^M (gdb) FAIL: gdb.base/list-missing-source.exp: list ... The problem is that the test-case does not expect to find a file main.c, but now it finds gdb.base/main.c. Fix this by using the more specific file name list-missing-source.c. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/list-missing-source.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/list-missing-source.exp b/gdb/testsuite/gdb.base/list-missing-source.exp index d6677fc0a5e..260ba4dcb7d 100644 --- a/gdb/testsuite/gdb.base/list-missing-source.exp +++ b/gdb/testsuite/gdb.base/list-missing-source.exp @@ -19,7 +19,7 @@ standard_testfile # Create a source file in the output directory. -set srcfile [standard_output_file main.c] +set srcfile [standard_output_file list-missing-source.c] set fd [open "$srcfile" w] puts $fd { int --------------CF1D90C581F1052080296DB0--