From: Simon Marchi <simon.marchi@polymtl.ca>
To: Ruslan Kabatsayev <b7.10110111@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
Date: Thu, 27 Jul 2017 09:27:00 -0000 [thread overview]
Message-ID: <ba695030652f117eb780ce4e1ba23685@polymtl.ca> (raw)
In-Reply-To: <CAHEcG94_2ePexhF1bne5awadQ10LuvJ4seJ0Tz6LW7kss+7Chw@mail.gmail.com>
On 2017-07-27 11:11, Ruslan Kabatsayev wrote:
>> I was thinking that perhaps that when focusing...
>>
>> a source view: s/n do source line stepping, S/N do assembly stepping
>> an asm view: s/n do assembly stepping, S/N do source line stepping
>>
>> Basically, they would switch role. Is that too confusing?
> This might be OK, but what if current focus in on registers window?
> Disable all single-key stepping?
Indeed. And when the user is in the "Source + Asm + Prompt"
configuration and the prompt is focused, what would we do? That's
perhaps a good idea in theory, but it would need to be more thought
through.
You patch provides a predictable behavior across all modes, so I don't
think we can go wrong with that.
Simon
next prev parent reply other threads:[~2017-07-27 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 6:13 [PATCH] " Ruslan Kabatsayev
2017-07-13 15:59 ` Eli Zaretskii
2017-07-13 18:19 ` Ruslan Kabatsayev
2017-07-13 19:04 ` Eli Zaretskii
2017-07-13 19:09 ` Ruslan Kabatsayev
2017-07-13 19:41 ` Eli Zaretskii
2017-07-26 19:19 ` [PING][PATCH] " Ruslan Kabatsayev
2017-07-26 20:53 ` Simon Marchi
2017-07-27 6:00 ` Ruslan Kabatsayev
2017-07-27 8:19 ` Simon Marchi
2017-07-27 9:12 ` Ruslan Kabatsayev
2017-07-27 9:27 ` Simon Marchi [this message]
2017-08-04 5:48 ` Ruslan Kabatsayev
2017-08-04 13:29 ` Simon Marchi
2017-08-04 19:11 ` Ruslan Kabatsayev
2017-08-04 21:04 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba695030652f117eb780ce4e1ba23685@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox