From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130818 invoked by alias); 27 Jul 2017 09:27:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129394 invoked by uid 89); 27 Jul 2017 09:25:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 09:25:31 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6R9PJXE000508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Jul 2017 05:25:24 -0400 Received: by simark.ca (Postfix, from userid 112) id ADDD41E98E; Thu, 27 Jul 2017 05:25:19 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 820871E194; Thu, 27 Jul 2017 05:25:18 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 27 Jul 2017 09:27:00 -0000 From: Simon Marchi To: Ruslan Kabatsayev Cc: gdb-patches@sourceware.org Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode In-Reply-To: References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> <7ee96675bc6f2307642fb638a9b65839@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 27 Jul 2017 09:25:19 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00421.txt.bz2 On 2017-07-27 11:11, Ruslan Kabatsayev wrote: >> I was thinking that perhaps that when focusing... >> >> a source view: s/n do source line stepping, S/N do assembly stepping >> an asm view: s/n do assembly stepping, S/N do source line stepping >> >> Basically, they would switch role. Is that too confusing? > This might be OK, but what if current focus in on registers window? > Disable all single-key stepping? Indeed. And when the user is in the "Source + Asm + Prompt" configuration and the prompt is focused, what would we do? That's perhaps a good idea in theory, but it would need to be more thought through. You patch provides a predictable behavior across all modes, so I don't think we can go wrong with that. Simon