From: Ruslan Kabatsayev <b7.10110111@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
Date: Wed, 26 Jul 2017 19:19:00 -0000 [thread overview]
Message-ID: <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> (raw)
In-Reply-To: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com>
So, the patch seems to have been approved by one reviewer (see [1]). But it
doesn't appear to have been pushed, nor do I have any further instructions
on how to get it merged. What should I do?
[1]: https://sourceware.org/ml/gdb-patches/2017-07/msg00165.html
On 13/07/17 09:07, Ruslan Kabatsayev wrote:
> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
> you have to use multi-key commands like "ni" and "si" to do single-stepping.
> This patch adds, in addition to "next" and "step" commands, corresponding
> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
> shortcuts of "N" and "S" respectively.
>
> gdb/ChangeLog:
>
> * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
> * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode
> ---
> gdb/doc/gdb.texinfo | 8 ++++++++
> gdb/tui/tui.c | 2 ++
> 2 files changed, 10 insertions(+)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index c167a86..56163ab 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -25415,6 +25415,10 @@ finish
> @item n
> next
>
> +@kindex N @r{(SingleKey TUI key)}
> +@item N
> +nexti
> +
> @kindex q @r{(SingleKey TUI key)}
> @item q
> exit the SingleKey mode.
> @@ -25427,6 +25431,10 @@ run
> @item s
> step
>
> +@kindex S @r{(SingleKey TUI key)}
> +@item S
> +stepi
> +
> @kindex u @r{(SingleKey TUI key)}
> @item u
> up
> diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
> index c918f3e..dbd86e8 100644
> --- a/gdb/tui/tui.c
> +++ b/gdb/tui/tui.c
> @@ -75,8 +75,10 @@ static const struct tui_char_command tui_commands[] = {
> { 'd', "down" },
> { 'f', "finish" },
> { 'n', "next" },
> + { 'N', "nexti" },
> { 'r', "run" },
> { 's', "step" },
> + { 'S', "stepi" },
> { 'u', "up" },
> { 'v', "info locals" },
> { 'w', "where" },
>
next prev parent reply other threads:[~2017-07-26 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 6:13 [PATCH] " Ruslan Kabatsayev
2017-07-13 15:59 ` Eli Zaretskii
2017-07-13 18:19 ` Ruslan Kabatsayev
2017-07-13 19:04 ` Eli Zaretskii
2017-07-13 19:09 ` Ruslan Kabatsayev
2017-07-13 19:41 ` Eli Zaretskii
2017-07-26 19:19 ` Ruslan Kabatsayev [this message]
2017-07-26 20:53 ` [PING][PATCH] " Simon Marchi
2017-07-27 6:00 ` Ruslan Kabatsayev
2017-07-27 8:19 ` Simon Marchi
2017-07-27 9:12 ` Ruslan Kabatsayev
2017-07-27 9:27 ` Simon Marchi
2017-08-04 5:48 ` Ruslan Kabatsayev
2017-08-04 13:29 ` Simon Marchi
2017-08-04 19:11 ` Ruslan Kabatsayev
2017-08-04 21:04 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com \
--to=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox