From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48316 invoked by alias); 26 Jul 2017 19:19:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48305 invoked by uid 89); 26 Jul 2017 19:19:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:45.2017 X-HELO: mail-lf0-f67.google.com Received: from mail-lf0-f67.google.com (HELO mail-lf0-f67.google.com) (209.85.215.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 19:19:46 +0000 Received: by mail-lf0-f67.google.com with SMTP id 65so3120821lfa.0 for ; Wed, 26 Jul 2017 12:19:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K+0y5YJ+4wjeNKxZj9wz7682azlfxtb27p2WmxoYefc=; b=UCml72B0AQkFBzeRTmB8RwPgKNoAhF2oas30GZ3Tqsn0Q6wL4IfCfgGX4Jz+QsI2qR 1g6pxGtpVZV/2ydMSXc/tqaVnMHEmumpRrnM3uV9URddqQjJZ7KY0YusLKxvGxGJUbnW uCrjbrZk90prdXvtheHvR1Clc+mCc9uUCeOy/lf868gPWDgO2gA/FvhREOyCZ77xDEaW L+WoVUUhaPI/wTrlU0PjhIe28MP/yb2dkvqCU54sykbOmnyv4mMDJYtgaU4NVPdp+LjE A5vnuBg5nm7mbfFkYbAqus7pCxzSEUXfdllhWgCvSnXfmmi3db8Wm+vkpbZ6YZmJw8sH uf7A== X-Gm-Message-State: AIVw113AE7DgFrrpE01v9CsigrxzBrWStYJrCFE/CYLZVxDJVwygoMgn odXhCZPr3rXlnUwC5VU= X-Received: by 10.46.21.71 with SMTP id 7mr833008ljv.50.1501096783591; Wed, 26 Jul 2017 12:19:43 -0700 (PDT) Received: from [192.168.0.204] ([91.215.122.25]) by smtp.gmail.com with ESMTPSA id w85sm1363578lfd.45.2017.07.26.12.19.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 12:19:42 -0700 (PDT) Subject: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: gdb-patches@sourceware.org References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> From: Ruslan Kabatsayev Message-ID: <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> Date: Wed, 26 Jul 2017 19:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00413.txt.bz2 So, the patch seems to have been approved by one reviewer (see [1]). But it doesn't appear to have been pushed, nor do I have any further instructions on how to get it merged. What should I do? [1]: https://sourceware.org/ml/gdb-patches/2017-07/msg00165.html On 13/07/17 09:07, Ruslan Kabatsayev wrote: > Currently, "layout asm" is not so useful as "layout src" with Single-Key mode: > you have to use multi-key commands like "ni" and "si" to do single-stepping. > This patch adds, in addition to "next" and "step" commands, corresponding > assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the > shortcuts of "N" and "S" respectively. > > gdb/ChangeLog: > > * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list > * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode > --- > gdb/doc/gdb.texinfo | 8 ++++++++ > gdb/tui/tui.c | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index c167a86..56163ab 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -25415,6 +25415,10 @@ finish > @item n > next > > +@kindex N @r{(SingleKey TUI key)} > +@item N > +nexti > + > @kindex q @r{(SingleKey TUI key)} > @item q > exit the SingleKey mode. > @@ -25427,6 +25431,10 @@ run > @item s > step > > +@kindex S @r{(SingleKey TUI key)} > +@item S > +stepi > + > @kindex u @r{(SingleKey TUI key)} > @item u > up > diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c > index c918f3e..dbd86e8 100644 > --- a/gdb/tui/tui.c > +++ b/gdb/tui/tui.c > @@ -75,8 +75,10 @@ static const struct tui_char_command tui_commands[] = { > { 'd', "down" }, > { 'f', "finish" }, > { 'n', "next" }, > + { 'N', "nexti" }, > { 'r', "run" }, > { 's', "step" }, > + { 'S', "stepi" }, > { 'u', "up" }, > { 'v', "info locals" }, > { 'w', "where" }, >