Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ruslan Kabatsayev <b7.10110111@gmail.com>
Cc: gdb-patches@sourceware.org, b7.10110111@gmail.com
Subject: Re: [PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
Date: Thu, 13 Jul 2017 15:59:00 -0000	[thread overview]
Message-ID: <83vamwgwf5.fsf@gnu.org> (raw)
In-Reply-To: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com>	(message from Ruslan Kabatsayev on Thu, 13 Jul 2017 09:07:50 +0300)

> From: Ruslan Kabatsayev <b7.10110111@gmail.com>
> Cc: Ruslan Kabatsayev <b7.10110111@gmail.com>
> Date: Thu, 13 Jul 2017 09:07:50 +0300
> 
> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
> you have to use multi-key commands like "ni" and "si" to do single-stepping.
> This patch adds, in addition to "next" and "step" commands, corresponding
> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
> shortcuts of "N" and "S" respectively.
> 
> gdb/ChangeLog:
> 
> 	* tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
> 	* doc/gdb.texinfo: Document the new shortcuts in Single-Key mode

This is fine with me, but please state in the ChangeLog the
functions/globals where you make the changes, and for gdb.texinfo
please state the name of the node (in parentheses).  I think the
existing ChangeLog entries show how we do that.

Thanks.


  reply	other threads:[~2017-07-13 15:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13  6:13 Ruslan Kabatsayev
2017-07-13 15:59 ` Eli Zaretskii [this message]
2017-07-13 18:19   ` Ruslan Kabatsayev
2017-07-13 19:04     ` Eli Zaretskii
2017-07-13 19:09       ` Ruslan Kabatsayev
2017-07-13 19:41         ` Eli Zaretskii
2017-07-26 19:19 ` [PING][PATCH] " Ruslan Kabatsayev
2017-07-26 20:53   ` Simon Marchi
2017-07-27  6:00     ` Ruslan Kabatsayev
2017-07-27  8:19       ` Simon Marchi
2017-07-27  9:12         ` Ruslan Kabatsayev
2017-07-27  9:27           ` Simon Marchi
2017-08-04  5:48             ` Ruslan Kabatsayev
2017-08-04 13:29               ` Simon Marchi
2017-08-04 19:11                 ` Ruslan Kabatsayev
2017-08-04 21:04                 ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vamwgwf5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=b7.10110111@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox