From: Ruslan Kabatsayev <b7.10110111@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
Date: Thu, 27 Jul 2017 06:00:00 -0000 [thread overview]
Message-ID: <CAHEcG95onBPe2QpWseG4GH22eXQxfYz6QnTd_dFnO1XX-Lz0AQ@mail.gmail.com> (raw)
In-Reply-To: <7ee96675bc6f2307642fb638a9b65839@polymtl.ca>
On 26 July 2017 at 23:53, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> On 2017-07-26 21:19, Ruslan Kabatsayev wrote:
>>
>> So, the patch seems to have been approved by one reviewer (see [1]). But
>> it
>> doesn't appear to have been pushed, nor do I have any further instructions
>> on how to get it merged. What should I do?
>
>
> Hi Ruslan,
>
> The patch is fine with me too, it seems to work well and it's a good idea.
>
> It might be a bit more work to implement (an idea for another patch maybe),
> but do you think it would be nice if n and s did next and step when focusing
> a source window, but did nexti and stepi when focusing an asm window? When
> in an asm window, I think you will much more likely want to use nexti/stepi
> than next/step, so maybe they should be bound to the n and s rather than N
> and S in that case?
This sounds like a great idea. If this is implemented, do you think N
and S are then useless and confusing (since n/s would be
focus-dependent while N/S won't)?
>
> In order to get the patch in, you have two choices: if you plan to
> contribute more in the future, we can get you write access to the repo, so
> that you can push your patches in once they are approved. Otherwise, we can
> push it for you. Let me know what you prefer.
Yes, I do plan to contribute in the future.
>
> Thanks,
>
> Simon
>
next prev parent reply other threads:[~2017-07-27 6:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 6:13 [PATCH] " Ruslan Kabatsayev
2017-07-13 15:59 ` Eli Zaretskii
2017-07-13 18:19 ` Ruslan Kabatsayev
2017-07-13 19:04 ` Eli Zaretskii
2017-07-13 19:09 ` Ruslan Kabatsayev
2017-07-13 19:41 ` Eli Zaretskii
2017-07-26 19:19 ` [PING][PATCH] " Ruslan Kabatsayev
2017-07-26 20:53 ` Simon Marchi
2017-07-27 6:00 ` Ruslan Kabatsayev [this message]
2017-07-27 8:19 ` Simon Marchi
2017-07-27 9:12 ` Ruslan Kabatsayev
2017-07-27 9:27 ` Simon Marchi
2017-08-04 5:48 ` Ruslan Kabatsayev
2017-08-04 13:29 ` Simon Marchi
2017-08-04 19:11 ` Ruslan Kabatsayev
2017-08-04 21:04 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHEcG95onBPe2QpWseG4GH22eXQxfYz6QnTd_dFnO1XX-Lz0AQ@mail.gmail.com \
--to=b7.10110111@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox