From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13603 invoked by alias); 27 Jul 2017 06:00:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12627 invoked by uid 89); 27 Jul 2017 05:59:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:74.125.82.54, H*RU:74.125.82.54 X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 05:59:23 +0000 Received: by mail-wm0-f54.google.com with SMTP id t201so89634775wmt.1 for ; Wed, 26 Jul 2017 22:59:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=L8cYqqgimGOhz+zVOO0Av0nXGvP/Z74FeYo0pOsNans=; b=Oj+eFSszxgkfY0wooeg4zkgRC53KtUy0Jt5uEtwINUg35MoKrt47WLVablI/BhCRK+ rlz8gV1YoanZ2FS5oGV53DXGsq528jgqiJ8/aDX9O8kcDtS7I12pbM0DjDHdBknzDYiQ aqecv5SNqqYIosUUdYQ1QE0AjDaJ2zrUE6BQQod/Hjn4pZCRDj44atjN9Ai7wRmD9qRT PtWWRFG6efSY1+VyOckDAT7lrR7HC4j8YiKpwHKYWacLA/Vnjct4IojuxBxRDVcWujJN YMD6KcWCCDx17oJQPp+80ydyrBDFaHWaiPIOF22JykUZP5iO7XmaiIacJttTu7EgyvqD WkVg== X-Gm-Message-State: AIVw112gUIa+/2Fvxfd0BywLWSzIsL9ZLDGH/sxFfDcvLVDy8Am+bmfN 2fcV0N7Tyqd9rHml2tjV5ukerUzIcg== X-Received: by 10.28.232.141 with SMTP id f13mr2171690wmi.59.1501135161215; Wed, 26 Jul 2017 22:59:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.126.147 with HTTP; Wed, 26 Jul 2017 22:59:20 -0700 (PDT) In-Reply-To: <7ee96675bc6f2307642fb638a9b65839@polymtl.ca> References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> <7ee96675bc6f2307642fb638a9b65839@polymtl.ca> From: Ruslan Kabatsayev Date: Thu, 27 Jul 2017 06:00:00 -0000 Message-ID: Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00418.txt.bz2 On 26 July 2017 at 23:53, Simon Marchi wrote: > On 2017-07-26 21:19, Ruslan Kabatsayev wrote: >> >> So, the patch seems to have been approved by one reviewer (see [1]). But >> it >> doesn't appear to have been pushed, nor do I have any further instructions >> on how to get it merged. What should I do? > > > Hi Ruslan, > > The patch is fine with me too, it seems to work well and it's a good idea. > > It might be a bit more work to implement (an idea for another patch maybe), > but do you think it would be nice if n and s did next and step when focusing > a source window, but did nexti and stepi when focusing an asm window? When > in an asm window, I think you will much more likely want to use nexti/stepi > than next/step, so maybe they should be bound to the n and s rather than N > and S in that case? This sounds like a great idea. If this is implemented, do you think N and S are then useless and confusing (since n/s would be focus-dependent while N/S won't)? > > In order to get the patch in, you have two choices: if you plan to > contribute more in the future, we can get you write access to the repo, so > that you can push your patches in once they are approved. Otherwise, we can > push it for you. Let me know what you prefer. Yes, I do plan to contribute in the future. > > Thanks, > > Simon >