Re: Gerrit request

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2019-10-15 1:12 p.m., Sergio Durigan Junior wrote:
> On Tuesday, October 15 2019, Tom Tromey wrote:
> 
>>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>>
>> Tom> This would be a lot better if the email included more of the patch
>> Tom> context.
>>
>> Simon> It doesn't seem to be possible out of the box.  The template can only work
>> Simon> with the data passed by Gerrit.  For a line comment, we only get the single
>> Simon> line it refers to:
>>
>> Simon>   https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328
>>
>> That's unfortunate.  For me this makes the patch reviews pretty
>> unreadable on the list.
>>
>> Maybe a gerrit feature request is in order.
> 
> I had found this limitation yesterday before Simon's reply, and I was
> looking into opening a bug report/feature request against gerrit, but
> they use Chromium's bugzilla, which requires a Google account to post
> things, so that's a no-no for me.
> 
> Maybe someone else can do that.

Well, I built Gerrit locally and was able to make a change to allow displaying a fixed
number of lines before the line the comment is attached to.  I'm just not sure I am
ready to go through the patch submission process, as it probably involves adding some
configuration option, documentation, testing, etc.  Just like when submitting a patch to
GDB :).

But I can at least open a feature request describing what I have prototyped.  I'll try to
do that later today.

Simon