From: Tom Tromey <tom@tromey.com>
To: "Tom de Vries \(Code Review\)" <gerrit@gnutoolchain-gerrit.osci.io>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
gdb-patches@sourceware.org, tdevries@suse.de,
sergiodj@sergiodj.net, andrew.burgess@embecosm.com
Subject: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)
Date: Mon, 14 Oct 2019 18:47:00 -0000 [thread overview]
Message-ID: <875zkrtd56.fsf_-_@tromey.com> (raw)
In-Reply-To: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> (Tom de Vries's message of "Mon, 14 Oct 2019 12:01:17 -0400")
Hi. I've been looking at the gerrit review email.
I'd like to suggest a way it could be improved.
Consider this review:
Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74
Tom> PS5, Line 74: pass $test
Tom> You could do pass $gdb_test_name and get rid of the test variable.
This would be a lot better if the email included more of the patch
context. As is, it's not very readable on the list. While I do want to
use gerrit, at the same time I think it would be nice to be able to
following the mailing list and get a reasonably complete idea of what's
going on.
Tom
next prev parent reply other threads:[~2019-10-14 18:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571064731000.I51b689458503240f24e401f054e6583d9172ebdf@gnutoolchain-gerrit.osci.io>
2019-10-14 15:50 ` Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst Simon Marchi (Code Review)
2019-10-14 15:51 ` Simon Marchi (Code Review)
2019-10-14 16:01 ` Tom de Vries (Code Review)
2019-10-14 18:47 ` Tom Tromey [this message]
2019-10-15 0:44 ` Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...) Simon Marchi
2019-10-15 1:16 ` Simon Marchi
2019-10-15 17:09 ` Gerrit request Tom Tromey
2019-10-15 17:12 ` Sergio Durigan Junior
2019-10-15 19:45 ` Simon Marchi
2019-10-14 16:06 ` Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst Simon Marchi (Code Review)
2019-10-14 16:07 ` Simon Marchi (Code Review)
2019-10-14 16:08 ` Tom de Vries (Code Review)
2019-10-14 16:14 ` Sourceware to Gerrit sync (Code Review)
2019-10-14 16:14 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zkrtd56.fsf_-_@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=gerrit@gnutoolchain-gerrit.osci.io \
--cc=sergiodj@sergiodj.net \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox