Re: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...)

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2019-10-14 2:06 p.m., Tom Tromey wrote:
> Hi.  I've been looking at the gerrit review email.
> I'd like to suggest a way it could be improved.
> 
> Consider this review:
> 
> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp 
> Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
> 
> Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 
> Tom> PS5, Line 74: 	pass $test
> Tom> You could do pass $gdb_test_name and get rid of the test variable.
> 
> This would be a lot better if the email included more of the patch
> context.  As is, it's not very readable on the list.  While I do want to
> use gerrit, at the same time I think it would be nice to be able to
> following the mailing list and get a reasonably complete idea of what's
> going on.
> 
> Tom

I'll take a look if it's possible to modify the templates to do so.

Simon