From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...
Date: Mon, 14 Oct 2019 16:01:00 -0000 [thread overview]
Message-ID: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571064731000.I51b689458503240f24e401f054e6583d9172ebdf@gnutoolchain-gerrit.osci.io>
Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 )
Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
LGTM, there's one nit that optionally could be fixed.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
File gdb/testsuite/gdb.mi/list-thread-groups-available.exp:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74
PS5, Line 74: pass $test
You could do pass $gdb_test_name and get rid of the test variable.
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf
Gerrit-Change-Number: 41
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-14 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571064731000.I51b689458503240f24e401f054e6583d9172ebdf@gnutoolchain-gerrit.osci.io>
2019-10-14 15:50 ` Simon Marchi (Code Review)
2019-10-14 15:51 ` Simon Marchi (Code Review)
2019-10-14 16:01 ` Tom de Vries (Code Review) [this message]
2019-10-14 18:47 ` Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...) Tom Tromey
2019-10-15 0:44 ` Simon Marchi
2019-10-15 1:16 ` Simon Marchi
2019-10-15 17:09 ` Gerrit request Tom Tromey
2019-10-15 17:12 ` Sergio Durigan Junior
2019-10-15 19:45 ` Simon Marchi
2019-10-14 16:06 ` Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst Simon Marchi (Code Review)
2019-10-14 16:07 ` Simon Marchi (Code Review)
2019-10-14 16:08 ` Tom de Vries (Code Review)
2019-10-14 16:14 ` Sourceware to Gerrit sync (Code Review)
2019-10-14 16:14 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@sergiodj.net \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox