From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82158 invoked by alias); 14 Oct 2019 16:01:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70410 invoked by uid 89); 14 Oct 2019 16:01:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 16:01:22 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C159020926; Mon, 14 Oct 2019 12:01:19 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 6890D205B2; Mon, 14 Oct 2019 12:01:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2C9AA29ECF; Mon, 14 Oct 2019 12:01:17 -0400 (EDT) X-Gerrit-PatchSet: 5 Date: Mon, 14 Oct 2019 16:01:00 -0000 From: "Tom de Vries (Code Review)" To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst... X-Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf X-Gerrit-Change-Number: 41 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5e552aa914fd5c91b420f91e3b0a4a1d15e6c489 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 14 Oct 2019 12:01:17 -0400 Reply-To: tdevries@suse.de, simon.marchi@polymtl.ca, sergiodj@sergiodj.net, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00354.txt.bz2 Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 ) Change subject: gdb.mi/list-thread-groups-available.exp: read entries one by one instead of increasing timeout ...................................................................... Patch Set 5: Code-Review+1 (1 comment) LGTM, there's one nit that optionally could be fixed. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp File gdb/testsuite/gdb.mi/list-thread-groups-available.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 PS5, Line 74: pass $test You could do pass $gdb_test_name and get rid of the test variable. -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I51b689458503240f24e401f054e6583d9172ebdf Gerrit-Change-Number: 41 Gerrit-PatchSet: 5 Gerrit-Owner: Simon Marchi Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom de Vries Gerrit-Comment-Date: Mon, 14 Oct 2019 16:01:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment