From: Sergio Durigan Junior <sergiodj@sergiodj.net>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
"Tom de Vries \(Code Review\)"
<gerrit@gnutoolchain-gerrit.osci.io>,
gdb-patches@sourceware.org, tdevries@suse.de,
andrew.burgess@embecosm.com
Subject: Re: Gerrit request
Date: Tue, 15 Oct 2019 17:12:00 -0000 [thread overview]
Message-ID: <87zhi20w77.fsf@paluero> (raw)
In-Reply-To: <87eezeorzg.fsf@tromey.com> (Tom Tromey's message of "Tue, 15 Oct 2019 11:09:39 -0600")
On Tuesday, October 15 2019, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Tom> This would be a lot better if the email included more of the patch
> Tom> context.
>
> Simon> It doesn't seem to be possible out of the box. The template can only work
> Simon> with the data passed by Gerrit. For a line comment, we only get the single
> Simon> line it refers to:
>
> Simon> https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328
>
> That's unfortunate. For me this makes the patch reviews pretty
> unreadable on the list.
>
> Maybe a gerrit feature request is in order.
I had found this limitation yesterday before Simon's reply, and I was
looking into opening a bug report/feature request against gerrit, but
they use Chromium's bugzilla, which requires a Google account to post
things, so that's a no-no for me.
Maybe someone else can do that.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2019-10-15 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571064731000.I51b689458503240f24e401f054e6583d9172ebdf@gnutoolchain-gerrit.osci.io>
2019-10-14 15:50 ` Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst Simon Marchi (Code Review)
2019-10-14 15:51 ` Simon Marchi (Code Review)
2019-10-14 16:01 ` Tom de Vries (Code Review)
2019-10-14 18:47 ` Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...) Tom Tromey
2019-10-15 0:44 ` Simon Marchi
2019-10-15 1:16 ` Simon Marchi
2019-10-15 17:09 ` Gerrit request Tom Tromey
2019-10-15 17:12 ` Sergio Durigan Junior [this message]
2019-10-15 19:45 ` Simon Marchi
2019-10-14 16:06 ` Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst Simon Marchi (Code Review)
2019-10-14 16:07 ` Simon Marchi (Code Review)
2019-10-14 16:08 ` Tom de Vries (Code Review)
2019-10-14 16:14 ` Sourceware to Gerrit sync (Code Review)
2019-10-14 16:14 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhi20w77.fsf@paluero \
--to=sergiodj@sergiodj.net \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=gerrit@gnutoolchain-gerrit.osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox