From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109594 invoked by alias); 15 Oct 2019 17:12:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109374 invoked by uid 89); 15 Oct 2019 17:12:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=Google X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 17:12:33 +0000 From: Sergio Durigan Junior To: Tom Tromey Cc: Simon Marchi , "Tom de Vries \(Code Review\)" , gdb-patches@sourceware.org, tdevries@suse.de, andrew.burgess@embecosm.com Subject: Re: Gerrit request References: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> <875zkrtd56.fsf_-_@tromey.com> <87eezeorzg.fsf@tromey.com> X-URL: http://blog.sergiodj.net Date: Tue, 15 Oct 2019 17:12:00 -0000 In-Reply-To: <87eezeorzg.fsf@tromey.com> (Tom Tromey's message of "Tue, 15 Oct 2019 11:09:39 -0600") Message-ID: <87zhi20w77.fsf@paluero> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00440.txt.bz2 On Tuesday, October 15 2019, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Tom> This would be a lot better if the email included more of the patch > Tom> context. > > Simon> It doesn't seem to be possible out of the box. The template can only work > Simon> with the data passed by Gerrit. For a line comment, we only get the single > Simon> line it refers to: > > Simon> https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328 > > That's unfortunate. For me this makes the patch reviews pretty > unreadable on the list. > > Maybe a gerrit feature request is in order. I had found this limitation yesterday before Simon's reply, and I was looking into opening a bug report/feature request against gerrit, but they use Chromium's bugzilla, which requires a Google account to post things, so that's a no-no for me. Maybe someone else can do that. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/