From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82134 invoked by alias); 14 Oct 2019 18:47:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81833 invoked by uid 89); 14 Oct 2019 18:47:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Was X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 18:47:37 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 91CD61B63F09 for ; Mon, 14 Oct 2019 13:06:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id K4k3i6oX1VUVYK4k3iqtVR; Mon, 14 Oct 2019 13:06:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LNyIf9oua/DNsKLHSGMqAKXhIMtlS97fEJeo3txZZp8=; b=l4pewkXBvZ0FdnZjs4kopyk/yC RYMaLcppSK5OFDd7PRqXBaZGHKiiBPm9nTpe76n7UBNS++WmjdG4eoLbY/ruljtXHGz1qMiekzPVJ 4xJt2p7upij5BKVCsp90Ax0Iv; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:49306 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iK4k2-003qqt-OI; Mon, 14 Oct 2019 12:06:46 -0600 From: Tom Tromey To: "Tom de Vries \(Code Review\)" Cc: Simon Marchi , gdb-patches@sourceware.org, tdevries@suse.de, sergiodj@sergiodj.net, andrew.burgess@embecosm.com Subject: Gerrit request (Was: Change in binutils-gdb[master]: gdb.mi/list-thread-groups-available.exp: read entries one by one inst...) References: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> Date: Mon, 14 Oct 2019 18:47:00 -0000 In-Reply-To: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> (Tom de Vries's message of "Mon, 14 Oct 2019 12:01:17 -0400") Message-ID: <875zkrtd56.fsf_-_@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00381.txt.bz2 Hi. I've been looking at the gerrit review email. I'd like to suggest a way it could be improved. Consider this review: Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp Tom> File gdb/testsuite/gdb.mi/list-thread-groups-available.exp: Tom> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/41/5/gdb/testsuite/gdb.mi/list-thread-groups-available.exp@74 Tom> PS5, Line 74: pass $test Tom> You could do pass $gdb_test_name and get rid of the test variable. This would be a lot better if the email included more of the patch context. As is, it's not very readable on the list. While I do want to use gerrit, at the same time I think it would be nice to be able to following the mailing list and get a reasonably complete idea of what's going on. Tom