From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98518 invoked by alias); 15 Oct 2019 19:45:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98503 invoked by uid 89); 15 Oct 2019 19:45:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Google X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 19:45:44 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x9FJjXEL032426 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2019 15:45:38 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9FJjXEL032426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1571168740; bh=EI9qdeg3dqIguK+xbmFKB06StTZsSfvr1eOLjx92SEk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AtEuKtAw8lITCiLEaQg2WfgsJL5f4QpN+qQiYQJw7H9i6II1c5Ex5uJwV9gyjDXTH H4Fr71ooZzLfnZ9elxb2lZrMOZ3l5XEgjNavJObTZfJhP9zKK9An9hp1ieXOq8sZWk GYUcTHbkXYStOawoc851nqnAzQubBi20b+c1XfK8= Received: from [172.16.0.148] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D15CD1E059; Tue, 15 Oct 2019 15:45:32 -0400 (EDT) Subject: Re: Gerrit request To: Sergio Durigan Junior , Tom Tromey Cc: "Tom de Vries (Code Review)" , gdb-patches@sourceware.org, tdevries@suse.de, andrew.burgess@embecosm.com References: <20191014160117.2C9AA29ECF@gnutoolchain-gerrit.osci.io> <875zkrtd56.fsf_-_@tromey.com> <87eezeorzg.fsf@tromey.com> <87zhi20w77.fsf@paluero> From: Simon Marchi Message-ID: Date: Tue, 15 Oct 2019 19:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87zhi20w77.fsf@paluero> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00449.txt.bz2 On 2019-10-15 1:12 p.m., Sergio Durigan Junior wrote: > On Tuesday, October 15 2019, Tom Tromey wrote: > >>>>>>> "Simon" == Simon Marchi writes: >> >> Tom> This would be a lot better if the email included more of the patch >> Tom> context. >> >> Simon> It doesn't seem to be possible out of the box. The template can only work >> Simon> with the data passed by Gerrit. For a line comment, we only get the single >> Simon> line it refers to: >> >> Simon> https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/mail/send/CommentSender.java#328 >> >> That's unfortunate. For me this makes the patch reviews pretty >> unreadable on the list. >> >> Maybe a gerrit feature request is in order. > > I had found this limitation yesterday before Simon's reply, and I was > looking into opening a bug report/feature request against gerrit, but > they use Chromium's bugzilla, which requires a Google account to post > things, so that's a no-no for me. > > Maybe someone else can do that. Well, I built Gerrit locally and was able to make a change to allow displaying a fixed number of lines before the line the comment is attached to. I'm just not sure I am ready to go through the patch submission process, as it probably involves adding some configuration option, documentation, testing, etc. Just like when submitting a patch to GDB :). But I can at least open a feature request describing what I have prototyped. I'll try to do that later today. Simon