[PATCH] sim: common: Fix pointer sign warnings

[PATCH] sim: common: Fix pointer sign warnings

[Stafford Horne]

When compiling we get the following warnings:

  common/cgen-accfp.c: In function ‘fixsfsi’:
  common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
     sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
                  ^
  common/cgen-accfp.c: In function ‘fixdfsi’:
  common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
     sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
                  ^
sim/common/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* cgen-accfp.c (fixsfsi): Change res from unsigned32 to signed32.
	(fixdfsi): Change res from unsigned32 to signed32.
---
 sim/common/cgen-accfp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/common/cgen-accfp.c b/sim/common/cgen-accfp.c
index 5d600c6e41..ab3a477bbe 100644
--- a/sim/common/cgen-accfp.c
+++ b/sim/common/cgen-accfp.c
@@ -364,7 +364,7 @@ static SI
 fixsfsi (CGEN_FPU* fpu, int how UNUSED, SF x)
 {
   sim_fpu op1;
-  unsigned32 res;
+  signed32 res;
 
   sim_fpu_32to (&op1, x);
   sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
@@ -375,7 +375,7 @@ static SI
 fixdfsi (CGEN_FPU* fpu, int how UNUSED, DF x)
 {
   sim_fpu op1;
-  unsigned32 res;
+  signed32 res;
 
   sim_fpu_64to (&op1, x);
   sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
-- 
2.13.5

Re: [PATCH] sim: common: Fix pointer sign warnings

[Mike Frysinger via Gdb-patches]

On 04 Oct 2017 00:44, Stafford Horne wrote:
> When compiling we get the following warnings:
> 
>   common/cgen-accfp.c: In function ‘fixsfsi’:
>   common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
>      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
>                   ^
>   common/cgen-accfp.c: In function ‘fixdfsi’:
>   common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
>      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
>                   ^

thanks for the fix, i've pushed it now.
there's one more too exactly like this:
 fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x)
 {
   sim_fpu op1;
-  unsigned64 res;
+  signed64 res;
 
   sim_fpu_64to (&op1, x);
   sim_fpu_to64i (&res, &op1, sim_fpu_round_near);
-mike

Re: [PATCH] sim: common: Fix pointer sign warnings

[Stafford Horne via Gdb-patches]

On Sun, Jan 31, 2021 at 03:26:35PM -0500, Mike Frysinger wrote:
> On 04 Oct 2017 00:44, Stafford Horne wrote:
> > When compiling we get the following warnings:
> > 
> >   common/cgen-accfp.c: In function ‘fixsfsi’:
> >   common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> >      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> >                   ^
> >   common/cgen-accfp.c: In function ‘fixdfsi’:
> >   common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> >      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> >                   ^
> 
> thanks for the fix, i've pushed it now.
> there's one more too exactly like this:
>  fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x)
>  {
>    sim_fpu op1;
> -  unsigned64 res;
> +  signed64 res;
>  
>    sim_fpu_64to (&op1, x);
>    sim_fpu_to64i (&res, &op1, sim_fpu_round_near);

Thanks, it's nice to see you back working on this.  Did you commit that fix in
fixdffi also?

-Stafford

Re: [PATCH] sim: common: Fix pointer sign warnings

[Mike Frysinger via Gdb-patches]

On 01 Feb 2021 10:31, Stafford Horne via Gdb-patches wrote:
> On Sun, Jan 31, 2021 at 03:26:35PM -0500, Mike Frysinger wrote:
> > On 04 Oct 2017 00:44, Stafford Horne wrote:
> > > When compiling we get the following warnings:
> > > 
> > >   common/cgen-accfp.c: In function ‘fixsfsi’:
> > >   common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> > >      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> > >                   ^
> > >   common/cgen-accfp.c: In function ‘fixdfsi’:
> > >   common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> > >      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> > >                   ^
> > 
> > thanks for the fix, i've pushed it now.
> > there's one more too exactly like this:
> >  fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x)
> >  {
> >    sim_fpu op1;
> > -  unsigned64 res;
> > +  signed64 res;
> >  
> >    sim_fpu_64to (&op1, x);
> >    sim_fpu_to64i (&res, &op1, sim_fpu_round_near);
> 
> Thanks, it's nice to see you back working on this.  Did you commit that fix in
> fixdffi also?

i did indeed include that
-mike