From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Stafford Horne <shorne@gmail.com>
Cc: GDB patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: common: Fix pointer sign warnings
Date: Sun, 31 Jan 2021 15:26:35 -0500 [thread overview]
Message-ID: <YBcSe2EzSohEBHwX@vapier> (raw)
In-Reply-To: <20171003154437.11329-1-shorne@gmail.com>
On 04 Oct 2017 00:44, Stafford Horne wrote:
> When compiling we get the following warnings:
>
> common/cgen-accfp.c: In function ‘fixsfsi’:
> common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> ^
> common/cgen-accfp.c: In function ‘fixdfsi’:
> common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> ^
thanks for the fix, i've pushed it now.
there's one more too exactly like this:
fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x)
{
sim_fpu op1;
- unsigned64 res;
+ signed64 res;
sim_fpu_64to (&op1, x);
sim_fpu_to64i (&res, &op1, sim_fpu_round_near);
-mike
next prev parent reply other threads:[~2021-01-31 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:44 Stafford Horne
2021-01-31 20:26 ` Mike Frysinger via Gdb-patches [this message]
2021-02-01 1:31 ` Stafford Horne via Gdb-patches
2021-02-01 2:14 ` Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBcSe2EzSohEBHwX@vapier \
--to=gdb-patches@sourceware.org \
--cc=shorne@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox