Re: [PATCH] sim: common: Fix pointer sign warnings

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

On 01 Feb 2021 10:31, Stafford Horne via Gdb-patches wrote:
> On Sun, Jan 31, 2021 at 03:26:35PM -0500, Mike Frysinger wrote:
> > On 04 Oct 2017 00:44, Stafford Horne wrote:
> > > When compiling we get the following warnings:
> > > 
> > >   common/cgen-accfp.c: In function ‘fixsfsi’:
> > >   common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> > >      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> > >                   ^
> > >   common/cgen-accfp.c: In function ‘fixdfsi’:
> > >   common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
> > >      sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
> > >                   ^
> > 
> > thanks for the fix, i've pushed it now.
> > there's one more too exactly like this:
> >  fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x)
> >  {
> >    sim_fpu op1;
> > -  unsigned64 res;
> > +  signed64 res;
> >  
> >    sim_fpu_64to (&op1, x);
> >    sim_fpu_to64i (&res, &op1, sim_fpu_round_near);
> 
> Thanks, it's nice to see you back working on this.  Did you commit that fix in
> fixdffi also?

i did indeed include that
-mike