From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Mv1KHhpkF2A9dwAAWB0awg (envelope-from ) for ; Sun, 31 Jan 2021 21:14:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 6DE641EF80; Sun, 31 Jan 2021 21:14:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BA7FC1E945 for ; Sun, 31 Jan 2021 21:14:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 04BD5384B406; Mon, 1 Feb 2021 02:14:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04BD5384B406 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612145689; bh=5gRtT/7jkFMMngOcZRD7iXuCqhBhQrwZqhaNIhfZwos=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NeDzvySNlLxFBUib8C+vka7rt7MzbE0nZ5a97MhnZDlXXGRMwJwl7kVypBBVUqot/ WUg/BvwBTYBw0XSMOB7t5mumR0kKN2OIPytVm2rjA7YXu2uENcsRhiLC62OCuBug1b KbTtdRTlKbVMm32glTzliuiZe9WTtUpJ1t6ZvUhE= Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id C41EF384B406 for ; Mon, 1 Feb 2021 02:14:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C41EF384B406 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id CE1F9340E9D; Mon, 1 Feb 2021 02:14:44 +0000 (UTC) Date: Sun, 31 Jan 2021 21:14:44 -0500 To: Stafford Horne Subject: Re: [PATCH] sim: common: Fix pointer sign warnings Message-ID: Mail-Followup-To: Stafford Horne , GDB patches References: <20171003154437.11329-1-shorne@gmail.com> <20210201013147.GH2002709@lianli.shorne-pla.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210201013147.GH2002709@lianli.shorne-pla.net> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: GDB patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 01 Feb 2021 10:31, Stafford Horne via Gdb-patches wrote: > On Sun, Jan 31, 2021 at 03:26:35PM -0500, Mike Frysinger wrote: > > On 04 Oct 2017 00:44, Stafford Horne wrote: > > > When compiling we get the following warnings: > > > > > > common/cgen-accfp.c: In function ‘fixsfsi’: > > > common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign] > > > sim_fpu_to32i (&res, &op1, sim_fpu_round_near); > > > ^ > > > common/cgen-accfp.c: In function ‘fixdfsi’: > > > common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign] > > > sim_fpu_to32i (&res, &op1, sim_fpu_round_near); > > > ^ > > > > thanks for the fix, i've pushed it now. > > there's one more too exactly like this: > > fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x) > > { > > sim_fpu op1; > > - unsigned64 res; > > + signed64 res; > > > > sim_fpu_64to (&op1, x); > > sim_fpu_to64i (&res, &op1, sim_fpu_round_near); > > Thanks, it's nice to see you back working on this. Did you commit that fix in > fixdffi also? i did indeed include that -mike